KEP-3619: implement RuntimeStatus.features.supplemental_groups_policy #8386
Conversation
Signed-off-by: Shingo Omura <[email protected]>
… field Signed-off-by: Shingo Omura <[email protected]>
|
@everpeace: No Jira issue with key KEP-3619 exists in the tracker at https://issues.redhat.com/. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hi @everpeace. Thanks for your PR. I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@everpeace: No Jira issue with key KEP-3619 exists in the tracker at https://issues.redhat.com/. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8386 +/- ##
==========================================
+ Coverage 49.51% 49.53% +0.02%
==========================================
Files 153 153
Lines 17085 17088 +3
==========================================
+ Hits 8460 8465 +5
+ Misses 7560 7559 -1
+ Partials 1065 1064 -1 |
|
@everpeace: No Jira issue with key KEP-3619 exists in the tracker at https://issues.redhat.com/. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@cri-o/cri-o-maintainers, please have a look. Thank you! |
| k8s.io/apimachinery v0.31.0-alpha.3 | ||
| k8s.io/client-go v0.31.0-alpha.3 | ||
| k8s.io/cri-api v0.31.0-alpha.3 | ||
| k8s.io/cri-api v0.31.0-beta.0.0.20240716205706-865479a3e1b3 |
There was a problem hiding this comment.
| k8s.io/cri-api v0.31.0-beta.0.0.20240716205706-865479a3e1b3 | |
| k8s.io/cri-api v0.31.0-beta.0 |
There was a problem hiding this comment.
@saschagrunert Sorry, unfortunately my k/k PR missed v1.31.0-beta.0😿 So, I need the latest version.
This is a required commit in cri-api repo: (merge commit: kubernetes/cri-api@865479a, the actual commit: kubernetes/cri-api@b8256fa). This is not included in the v0.31.0-beta.0 tag.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everpeace, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add an implementation of
RuntimeStatus.features.supplemental_groups_policyto CRI-O so that Kubernetes users can recognize if the CRI implementation supports SupplementalGroupsPolicy.This also helps CI tests can gracefully skip if the CRI implementation does not support SupplementalGroupsPolicy.
Related to:
For:
Depends on:
Depended by:
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
I'm aiming to alpha-release this feature in Kubernetes 1.31 (expected release date is 13th August 2024). Thank you, in advance 🙇🙇
Does this PR introduce a user-facing change?