Skip to content

KEP-3619: implement RuntimeStatus.features.supplemental_groups_policy #8386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2024
+862 −527
Merged

KEP-3619: implement RuntimeStatus.features.supplemental_groups_policy #8386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f05dac5
KEP-3619: update cri-api version
everpeace Jul 17, 2024
c2c0bae
KEP-3619: implement RuntimeStatus.features.supplemental_groups_policy…
everpeace Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ require (
k8s.io/api v0.31.0-alpha.3
k8s.io/apimachinery v0.31.0-alpha.3
k8s.io/client-go v0.31.0-alpha.3
k8s.io/cri-api v0.31.0-alpha.3
k8s.io/cri-api v0.31.0-beta.0.0.20240716205706-865479a3e1b3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
k8s.io/cri-api v0.31.0-beta.0.0.20240716205706-865479a3e1b3
k8s.io/cri-api v0.31.0-beta.0

Copy link
Contributor Author

@everpeace everpeace Jul 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saschagrunert Sorry, unfortunately my k/k PR missed v1.31.0-beta.0😿 So, I need the latest version.

This is a required commit in cri-api repo: (merge commit: kubernetes/cri-api@865479a, the actual commit: kubernetes/cri-api@b8256fa). This is not included in the v0.31.0-beta.0 tag.

k8s.io/klog/v2 v2.130.1
k8s.io/kubelet v0.31.0-alpha.3
k8s.io/utils v0.0.0-20240502163921-fe8a2dddb1d0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2085,8 +2085,8 @@ k8s.io/apiserver v0.31.0-alpha.3 h1:qPOb3O4ACmpKL80wfmokP/y9EilUr/KwuKlALyFntlw=
k8s.io/apiserver v0.31.0-alpha.3/go.mod h1:dyQbHQnV7VDH+KQMtX6g1muC3K7SeIpe8brCjBp4DQ8=
k8s.io/client-go v0.31.0-alpha.3 h1:g9wbiICMHrFwxl3pGi63v2wPXL4Mk4z0ps6kMRHBcSI=
k8s.io/client-go v0.31.0-alpha.3/go.mod h1:vVK9F/qT7echvzsBfdH5EeH8WH6+SMcY7IbYJCZa6fU=
k8s.io/cri-api v0.31.0-alpha.3 h1:sLth/Vdn/TpwCY3UZRIo4sme2trzl+nGYBUnQAypfzQ=
k8s.io/cri-api v0.31.0-alpha.3/go.mod h1:++pZmPOodkvdUTNnXKrhFD68SD9WBKVP7rwC9frDbzU=
k8s.io/cri-api v0.31.0-beta.0.0.20240716205706-865479a3e1b3 h1:Ajq0xvhs7HDrZVLgqUenylY8i4BkaazJzfeM+fh63AU=
k8s.io/cri-api v0.31.0-beta.0.0.20240716205706-865479a3e1b3/go.mod h1:Po3TMAYH/+KrZabi7QiwQI4a692oZcUOUThd/rqwxrI=
k8s.io/klog/v2 v2.130.1 h1:n9Xl7H1Xvksem4KFG4PYbdQCQxqc/tTUyrgXaOhHSzk=
k8s.io/klog/v2 v2.130.1/go.mod h1:3Jpz1GvMt720eyJH1ckRHK1EDfpxISzJ7I9OYgaDtPE=
k8s.io/kube-openapi v0.0.0-20240228011516-70dd3763d340 h1:BZqlfIlq5YbRMFko6/PM7FjZpUb45WallggurYhKGag=
Expand Down
3 changes: 3 additions & 0 deletions server/runtime_status.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ func (s *Server) Status(ctx context.Context, req *types.StatusRequest) (*types.S
networkCondition,
},
},
Features: &types.RuntimeFeatures{
SupplementalGroupsPolicy: true,
},
}

for name, runtime := range s.config.Runtimes {
Expand Down
Loading