ENT-14161: Limit RPC login attempts #8033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adelel1
reviewed
Dec 9, 2025
node/src/main/kotlin/net/corda/node/internal/security/RPCSecurityManagerImpl.kt
Outdated
Show resolved
Hide resolved
adelel1
reviewed
Dec 9, 2025
node/src/main/kotlin/net/corda/node/internal/security/RPCSecurityManagerImpl.kt
Outdated
Show resolved
Hide resolved
rick-r3
reviewed
Dec 9, 2025
node/src/main/kotlin/net/corda/node/internal/security/RPCSecurityManagerImpl.kt
Outdated
Show resolved
Hide resolved
node/src/main/kotlin/net/corda/node/internal/security/RPCSecurityManagerImpl.kt
Outdated
Show resolved
Hide resolved
node/src/main/kotlin/net/corda/node/internal/security/RPCSecurityManagerImpl.kt
Outdated
Show resolved
Hide resolved
rick-r3
reviewed
Dec 9, 2025
node/src/main/kotlin/net/corda/node/internal/security/RPCSecurityManagerImpl.kt
Outdated
Show resolved
Hide resolved
rick-r3
reviewed
Dec 16, 2025
...src/main/kotlin/net/corda/node/services/messaging/RateLimitingActiveMQJAASSecurityManager.kt
Outdated
Show resolved
Hide resolved
rick-r3
reviewed
Dec 18, 2025
Contributor
rick-r3
left a comment
There was a problem hiding this comment.
I think the algorithm and implementation is now basically right. Just made some detailed comments on the code now.
...src/main/kotlin/net/corda/node/services/messaging/RateLimitingActiveMQJAASSecurityManager.kt
Outdated
Show resolved
Hide resolved
...src/main/kotlin/net/corda/node/services/messaging/RateLimitingActiveMQJAASSecurityManager.kt
Outdated
Show resolved
Hide resolved
...src/main/kotlin/net/corda/node/services/messaging/RateLimitingActiveMQJAASSecurityManager.kt
Outdated
Show resolved
Hide resolved
...src/main/kotlin/net/corda/node/services/messaging/RateLimitingActiveMQJAASSecurityManager.kt
Outdated
Show resolved
Hide resolved
...src/main/kotlin/net/corda/node/services/messaging/RateLimitingActiveMQJAASSecurityManager.kt
Outdated
Show resolved
Hide resolved
...src/main/kotlin/net/corda/node/services/messaging/RateLimitingActiveMQJAASSecurityManager.kt
Outdated
Show resolved
Hide resolved
...src/main/kotlin/net/corda/node/services/messaging/RateLimitingActiveMQJAASSecurityManager.kt
Outdated
Show resolved
Hide resolved
...src/main/kotlin/net/corda/node/services/messaging/RateLimitingActiveMQJAASSecurityManager.kt
Outdated
Show resolved
Hide resolved
...src/main/kotlin/net/corda/node/services/messaging/RateLimitingActiveMQJAASSecurityManager.kt
Outdated
Show resolved
Hide resolved
rick-r3
approved these changes
Dec 19, 2025
adelel1
reviewed
Dec 23, 2025
Comment on lines
+68
to
+69
| log.warn(printWarnMessage(user, remaining)) | ||
| throw FailedLoginException(printWarnMessage(user, remaining)) |
Collaborator
There was a problem hiding this comment.
Just a comment, if these logs turn out to be an issue. Then log4j2.xml can be used to filter them out if needed.
adelel1
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added optional RPC authentication rate-limiting to protect nodes from brute-force or dictionary attacks. When enabled, repeated failed logins trigger an exponential backoff, temporarily blocking further attempts. All parameters — base delay, maximum delay, and attempt expiry — are fully configurable programmatically and via node.conf, while the default behaviour remains unchanged (no rate limiting unless explicitly enabled).
PR Checklist:
https://docs.r3.com/release-notes.html)?Thanks for your code, it's appreciated! :)