ENT-14161: Limit RPC login attempts #8033
PR comments
- Loading branch information
commit 9913dde56ef6fec3db651f6b4c706a551a2b1c9a
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,88 +1,132 @@ | ||
| package net.corda.node.services.messaging | ||
|
|
||
| import com.github.benmanes.caffeine.cache.Cache | ||
| import com.github.benmanes.caffeine.cache.Caffeine | ||
| import org.apache.activemq.artemis.core.config.impl.SecurityConfiguration | ||
| import org.apache.activemq.artemis.spi.core.protocol.RemotingConnection | ||
| import org.apache.activemq.artemis.spi.core.security.ActiveMQJAASSecurityManager | ||
| import java.security.MessageDigest | ||
| import java.time.Duration | ||
| import java.time.Instant | ||
| import java.util.Base64 | ||
| import java.util.concurrent.TimeUnit | ||
| import javax.security.auth.Subject | ||
| import javax.security.auth.login.FailedLoginException | ||
| import kotlin.math.pow | ||
|
|
||
| class RateLimitingActiveMQJAASSecurityManager( | ||
| configurationName: String, | ||
| configuration: SecurityConfiguration, | ||
| rateLimitConfig: net.corda.node.services.config.SecurityConfiguration.AuthService.Options.RateLimit? | ||
| ) : ActiveMQJAASSecurityManager(configurationName, configuration) { | ||
|
|
||
| private data class Attempt(val count: Int, val nextAllowed: Instant) | ||
|
|
||
| private val baseDelaySeconds = rateLimitConfig?.backoffBaseSeconds ?: 2L | ||
| @Suppress("MagicNumber") | ||
| private val maxDelaySeconds = rateLimitConfig?.backoffMaxSeconds ?: 60L | ||
| @Suppress("MagicNumber") | ||
| private val attemptExpireMinutes = rateLimitConfig?.attemptExpireMinutes ?: 15L | ||
|
|
||
| private val userFreeAttempts = 3 | ||
| private val ipFreeAttempts = 10 | ||
|
|
||
| private val userAttempts = | ||
| Caffeine.newBuilder() | ||
| .expireAfterWrite(attemptExpireMinutes, TimeUnit.MINUTES) | ||
| .maximumSize(10_000) | ||
| .build<String, Attempt>() | ||
|
|
||
| private val ipAttempts = | ||
| Caffeine.newBuilder() | ||
| .expireAfterWrite(15, TimeUnit.MINUTES) | ||
| .maximumSize(10_000) | ||
| .build<String, Attempt>() | ||
|
|
||
| override fun authenticate(user: String?, password: String?, remotingConnection: RemotingConnection?, securityDomain: String?): Subject? { | ||
|
|
||
| val now = Instant.now() | ||
| val ip = extractIp(remotingConnection) | ||
| val userKey = user?.let { hash("$it|$ip") } | ||
| val ipKey = hash(ip) | ||
|
|
||
| // 1. If user+IP suspended -> immediately reject | ||
| if (userKey != null) { | ||
| userAttempts.getIfPresent(userKey)?.let { userAttempt -> | ||
| if (now.isBefore(userAttempt.nextAllowed)) { | ||
jakubzadroga marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| val remaining = Duration.between(now, userAttempt.nextAllowed).seconds | ||
jakubzadroga marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| throw FailedLoginException("Login temporarily suspended for user '$user'. Try again in $remaining seconds.") | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // 2. Attempt authentication | ||
| return try { | ||
| val subject = super.authenticate(user, password, remotingConnection, securityDomain) | ||
|
|
||
| // success - clear user cache only | ||
| if (userKey != null) { | ||
| userAttempts.invalidate(userKey) | ||
| } | ||
| subject | ||
| } catch (fle: FailedLoginException) { | ||
|
|
||
| // 3. Record IP failure | ||
| recordFailure(ipAttempts, ipKey, ipFreeAttempts, now) | ||
|
|
||
| // 4, If IP suspended -> reject | ||
| ipAttempts.getIfPresent(ipKey)?.let { ipAttempt -> | ||
| if (now.isBefore(ipAttempt.nextAllowed)) { | ||
jakubzadroga marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| val remaining = Duration.between(now, ipAttempt.nextAllowed).seconds | ||
jakubzadroga marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| throw FailedLoginException("Login temporarily suspended from IP $ip. Try again in $remaining seconds.") | ||
| } | ||
| } | ||
|
|
||
| // 5. Record user+IP failure | ||
| if (userKey != null) { | ||
| recordFailure(userAttempts, userKey, userFreeAttempts, now) | ||
| } | ||
|
|
||
| // 6. If user+IP suspected -> reject | ||
| if (userKey != null) { | ||
| userAttempts.getIfPresent(userKey)?.let { userAttempt -> | ||
| if (now.isBefore(userAttempt.nextAllowed)) { | ||
jakubzadroga marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| val remaining = Duration.between(now, userAttempt.nextAllowed).seconds | ||
jakubzadroga marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| throw FailedLoginException("Login temporarily suspended for user '$user'. Try again in $remaining seconds.") | ||
| } | ||
| } | ||
| } | ||
| // 7. Plain authentication failure | ||
| throw fle | ||
| } | ||
| } | ||
|
|
||
| private fun recordFailure( | ||
| cache: Cache<String, Attempt>, | ||
| key: String, | ||
| freeAttempts: Int, | ||
| now: Instant | ||
| ) { | ||
| val prev = cache.getIfPresent(key) | ||
jakubzadroga marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| val newCount = (prev?.count ?: 0) + 1 | ||
|
|
||
| val delay = | ||
| if (newCount <= freeAttempts) 0 | ||
jakubzadroga marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| else { | ||
| val exp = newCount - freeAttempts - 1 | ||
| (baseDelaySeconds * 2.0.pow(exp)).toLong().coerceAtMost(maxDelaySeconds) | ||
| } | ||
| cache.put(key, Attempt(newCount, now.plusSeconds(delay))) | ||
| } | ||
|
|
||
| private fun extractIp(remotingConnection: RemotingConnection?): String { | ||
| val raw = remotingConnection?.remoteAddress ?: "unknown" | ||
| return raw.substringAfter('/').substringBefore(':') | ||
| } | ||
|
|
||
| private fun hash(value: String): String { | ||
| return Base64.getEncoder().encodeToString( | ||
| MessageDigest.getInstance("SHA-256").digest(value.toByteArray()) | ||
| ) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.