Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Conversation

@chris-cwa
Copy link
Contributor

No description provided.

d4rken and others added 30 commits October 29, 2020 10:22
* FileLoggerPlus - RX added - preparation

* Buffer config as constants

* avoid empty lines

* Reworked logging to file - wip

* Collecting errors to dao - wip

* Added crash report to app db and created module

* do it

* inject crashReportTree - wip

* use dagger injection

* retrieve short hash via gradle

* removed todo

* Updated database to version 2 for new ReportEntity - old base

* deprecated old engagement - RX not allowed anymore

* use global scope for coroutines in crash report tree - ktlint clean

* added menu item - error reporter (replace later to new structure)

* basic recylcerview and fragment added to menu - wip

* deprecated data class

* Delete CrashModel.kt

* crash report list item to use data binding

* separated Reporteradapter - klint clean

* use separated Adapter in ReporterFragment - cleanup

* Added ErrorReporterViewModel - connected data to list

* dependency injection for crash report, better structure, todo cleanup

* some refactoring, cleanup, ktlint

* adjustments for 1.6.x

* temp action to open crash report fragment

* removed testcode

* updated layout - wip

* connected view & data

* satisfy circle ci checks

* plant reportingTree, testbutton, klint clean

* updated layout for reporter - wip

* better format and layout

* better message handling

* missing icons for errors on debug

* Adjusted error report index

* Removed ugly show button, report clickable

* Added SettingsCrashReportDetailsFragment & corresponding files

* fixed merge inconsistence

* fixed injection overall

* use livedata

* details added to report - wip

* beauty

* share & layout root preparation

* make error report shareable

* removed Dispatcher.IO for example

* Introduce skeleton classes for bugreporting

* Refactoring, adjustments to be able to build again

* Created BugEventEntity, Changed id to Long for more efficiency,  Removed unused events

* refactored ui to deviceForTesters, testmenu etc

* adjusted interfaces & related, better structure

* uses own db, added converter, adjusted modules

* adjusted bugrepo, defaultbugrepo

* shared report, better visualisation

* changed crash db name

* Implemented DefaultBugRepository

* Added device info to BugEvent, BugReporter collects Tag, Added default impl of BugEvent etc

* corrected bug in RollingLogHistory

* removed deprecated crash package

* quickfix - wip

* cleanup

* cleanUp, adjusted simulation button to new structure

* moved bug related layouts to deviceForTesters package

* removed old RX dependenies and related context

* fix build for deviceDebug

* lint clean

* current set of relevant exceptions as before

* attach log to output

* improved output

* Delete obsolet ic_bug in main

* Delete ic_coffee.xml

* changed shortID to shortCommitHash for better transparency

* companion to bottom

* removed string encapsulation

* cleanup unused import and blank line - PR Comment

* typo fixed

* rm empty line

* removed relict module

* layout fix

* adjusted unrelated method call

* fixed package inkonsistence

* Use flow instead of livedata in non-ui

* better fun naming

* Replaced interface with inline listener

* Improved SettingsCrashReportDetailsFragment and SettingsCrashReportViewModel, formatting adjusted

* cleaned converter

* Delete Project.xml

* added log statement to DefaultBugRepository

* adjusted magical number

* Use CommonConverters instead of unique Converters in BugDatabase

* Extension function for the resuce -defaultBugRepository

* removed FormatterCrashReport completly

* changed long to UUID

* satisfy buggy ktlint checks

* Update SettingsCrashReportViewModel.kt

use postvalue

* avoid passing viewmodel

* store appVersionCode as Long for beeing futuresave

* Update SettingsCrashReportViewModel.kt

removed lazy init

* Changed BugDatabase to factory pattern

Co-authored-by: Matthias Urhahn <[email protected]>
Co-authored-by: harambasicluka <[email protected]>
Change-Id: Icbc05a9bc4c2d638335e918ece24bf772769b4c0
* Allow WorkerManager's workers to be injected.

* Remove static access for Playbook

* Add mock for playbook so dagger can create the worker factory map.
…2997) (#1496)

* Initial refactoring on the Submission flow.
Trimming down SubmissionViewModel.kt

* Refactored submission tan, and began instrumentation tests. Intro, Dispatcher and Tan complete

* Adapted instrumentation tests after merge - added ToDos

* Completed boilerplate submission instrumentation tests. Verification and screenshots to follow

* Fix lints

* More lint issues.

* Fix instrumentation test dependency missmatch.

* Move screenshot related permissions into a debug AndroidManifest.xml,
such that they don't get included in production builds.

* Added missing new line to manifest

Co-authored-by: Oliver Zimmerman <[email protected]>
Co-authored-by: Kolya Opahle <[email protected]>
Co-authored-by: harambasicluka <[email protected]>
Push RC build to T-Systems (EXPOSUREAPP-3325)
* converted risk level transaction to task

* simplified

* fixed config: timeout is now duration

* less is more

* arrangement + empty lines

* Added additional checks to notification of exposure/test-result to check for finished submission

Signed-off-by: Kolya Opahle <[email protected]>

* submit risk level task requests

* - unreachable catch blocks

* housekeeping

* satisfied ktlint + detekt

* fixed flow: isRefreshing

* fixed flavour for testers

* refactored benchmark

* fixed package declaration

* unit tests

* fixed injection

* fixed tests

* comments from PR

* fixed injection

* fixed lint issues

* fixed another merge conflict

* - unused class

* map task factory

* fulfilled comment style wishes

* fixed tests suspended by changes from develop branch

* Update Corona-Warn-App/src/main/java/de/rki/coronawarnapp/risk/DefaultRiskLevels.kt

#1412 (comment)

Co-authored-by: Kolya Opahle <[email protected]>

* changes from PR

* fixed a test

* show logs, ktlint issues

* made log tag non-nullable

* improvements from reviewers

* reduced static access

* Saint Pipeline, please give me the green light

* toString()

* ktlint + di

* fixed test

Co-authored-by: Kolya Opahle <[email protected]>
Co-authored-by: harambasicluka <[email protected]>
…1518)

* Fixed lived data in VM being filtered resulting in issue where it wouldn't be updated in the future

* Removed unused imports

* Delete Project.xml

Removed unnecessary file.

* Forgot to add if statement in observer

* Revert Project.xml
* moved getHash call to DeviceForTesters Flavor to satisfy CircleCI

* added variant prefix
* On flavor "deviceForTesters" show a toast to tell the testers/devs which environment is currently activated.

* Add unit tests for new "Current env: ..." toast.

Co-authored-by: Ralf Gehrer <[email protected]>
* Regex updated and new test cases added

* test cases refactored, regex improvement, obsolete tests removed
* Test run

* Test run

* Test run

* Clean up

* Property fix

* Quotes fix

* merge conflict solved

Co-authored-by: BMItter <[email protected]>
Co-authored-by: BMItter <[email protected]>
#1507)

* Added required strings.

* Updated strings according to ticket description.

Co-authored-by: harambasicluka <[email protected]>
# Conflicts:
#	gradle.properties
Merge release/1.6.x into release/1.7.x (DEV)
* CodeStyle needs to be part of the project.

* Correct XML formatting.
janetback and others added 4 commits November 5, 2020 09:25
* Split and hide the protobuf config behind interfaces with individual mappers responsible for creating the desired formats.

* Merge branch 'release/1.7.x' into feature/3455-more-frequent-riskscore-updates-configs

# Conflicts:
#	Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/risklevel/ui/TestRiskLevelCalculationFragmentCWAViewModel.kt
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/transaction/RiskLevelTransaction.kt
#	Corona-Warn-App/src/test/java/de/rki/coronawarnapp/transaction/RiskLevelTransactionTest.kt

* Make the AppConfig observable.
Provide the server time offset.
Offer a lastUpdatedAt timestamp.
Add an app config specific test screen.
Clean up test screens a bit and move debug options out of API test options.

* Fix test regression due to refactoring (moved code around).

* Store the server timestamp and offset at retrieval.
Switch to config storage via json to be able to store additional meta data fields (i.e. time).

* KLint and Me have a hate relationship based on both mutual admiration.

* Fix time offset parsing being locale dependent.

* Fix broken unit tests.

* Improve offset accuracy, move before unzipping.

* Fix overly long livedata subscription to results (viewmodel scope vs observer scope)

* Add mapping for the new protobuf configs + tests.

* For cached (retrofit) response, we need to check the cacheResponse and its timestamps
to determine an accurate time offset.

* Exposure a boolean property to tell us when a fallback config is being used.

* Hide the observable flow<ConfigData> behind a method that can automatically triggers refreshes.

* Use a common mapper interface.

* Address PR comments and KLints.

* Fix refactoring regression.

* Improve config unzipping code.

* Add flag to forward exception thrown during HotDataFlow.kt initialization.

* Don't specify a default context via singleton.

* Move download and fallback logic into it's own class just responsible for sourcing the config: "AppConfigSource".
"AppConfigProvider" is now only responsible for making it available.

* Simplify current concepts for making the app config observable until we have a default configuration.

* Improve app config test screen, delete options, better feedback.
Show toast instead of crash on errors.

* Fixed GSON serialization not encoding/decoding the byte array correctly.
Added specific type adapters for instant and duration to get cleaner json.

* Remove type adapters from base gson due to conflict with CalculationTrackerStorage.

* We want to default to forced serialization of instant by our converters, instead of using the default serialization which will differ
between Java8.Instant and JodaTime.Instant, to prevent future headaches there, register explicit converters by default,
and overwrite them if necessary (currently only needed for CalculationTrackerStorage.kt).

* Improve AppConfigServer code readability by moving code into extensions.

* Fix merge conflicts

* Throw a more specific exception if gson type decoding fails due to malformed base64 encoding.

* Add unit test for Gson ByteArrayAdapter.

Co-authored-by: harambasicluka <[email protected]>
@chris-cwa chris-cwa requested a review from a team November 5, 2020 13:17
@harambasicluka harambasicluka changed the title 1.7.x to 1.8.x 1.7.x to 1.8.x (DEV) Nov 5, 2020
@harambasicluka harambasicluka added the maintainers Tag pull requests created by maintainers label Nov 5, 2020
@harambasicluka harambasicluka added this to the 1.8.0 milestone Nov 5, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 6 Code Smells

26.7% 26.7% Coverage
1.1% 1.1% Duplication

@harambasicluka harambasicluka merged commit 3d7bfdd into release/1.8.x Nov 5, 2020
@harambasicluka harambasicluka deleted the 1.7.x_to_1.8.x branch November 5, 2020 13:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

maintainers Tag pull requests created by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.