This repository was archived by the owner on Jun 20, 2023. It is now read-only.
Introduce skeleton classes for UI tests and screenshots (EXPOSUREAPP-2997) #1496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trimming down SubmissionViewModel.kt
…spatcher and Tan complete
…and screenshots to follow
…tion-screenshots-v2 # Conflicts: # Corona-Warn-App/build.gradle # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/main/MainActivityModule.kt
such that they don't get included in production builds.
…tion-screenshots-v2
kolyaopahle
reviewed
Oct 29, 2020
Contributor
|
Checked on WRU-XD,
|
AlexanderAlferov
approved these changes
Oct 30, 2020
Contributor
AlexanderAlferov
left a comment
There was a problem hiding this comment.
App tested. Calendar working fine. Lgtm
AndroidMedaGalaxy
approved these changes
Oct 30, 2020
Member
AndroidMedaGalaxy
left a comment
There was a problem hiding this comment.
QR and TAN submission flow tests were successful.
LGTM “ヽ(´▽｀)ノ”
Kolpa
approved these changes
Oct 30, 2020
Contributor
Kolpa
left a comment
There was a problem hiding this comment.
LGTM, still some more refactoring needed but too much to put into this pr as well
kolyaopahle
approved these changes
Oct 30, 2020
Contributor
kolyaopahle
left a comment
There was a problem hiding this comment.
Now also approved using the right github account '^^
BMItr
approved these changes
Oct 30, 2020
…tion-screenshots-v2
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission refactoring and many skeletons for UI tests, and some fastlane screenshot logic.
Getting this merge ready such that it does not become too stale too merge.
Replaces #1467
Test