Skip to content

Rename tests and test files #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 13, 2024
Merged

Rename tests and test files #786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b9ecc10
Rename tests and test files
Feb 9, 2024
6c2c62b
Fix annoying line
Feb 10, 2024
70c3253
Fix grammar
Feb 10, 2024
9c1532a
Update testing/grpcwebclient/known_failing.txt
smaye81 Feb 13, 2024
cecd24c
Feedback
Feb 13, 2024
eac7460
Rename
Feb 13, 2024
42488eb
Merge branch 'main' into sayers/renaming
smaye81 Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions internal/app/connectconformance/testsuites/data/basic.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
name: Basic
# The Basic suite represents basic success and error response tests across
# all types of streams.
testCases:
# Unary Tests -----------------------------------------------------------------
- request:
testName: unary success
testName: unary/success
service: connectrpc.conformance.v1.ConformanceService
method: Unary
streamType: STREAM_TYPE_UNARY
Expand All @@ -20,23 +22,23 @@ testCases:
- name: x-custom-trailer
value: ["bing"]
- request:
testName: unary empty definition
testName: unary/empty-definition
service: connectrpc.conformance.v1.ConformanceService
method: Unary
streamType: STREAM_TYPE_UNARY
requestMessages:
- "@type": type.googleapis.com/connectrpc.conformance.v1.UnaryRequest
responseDefinition:
- request:
testName: unary no definition
testName: unary/no-definition
service: connectrpc.conformance.v1.ConformanceService
method: Unary
streamType: STREAM_TYPE_UNARY
requestMessages:
- "@type": type.googleapis.com/connectrpc.conformance.v1.UnaryRequest
# Client Stream Tests ---------------------------------------------------------
- request:
testName: client stream success
testName: client-stream/success
service: connectrpc.conformance.v1.ConformanceService
method: ClientStream
streamType: STREAM_TYPE_CLIENT_STREAM
Expand All @@ -56,23 +58,23 @@ testCases:
- "@type": type.googleapis.com/connectrpc.conformance.v1.ClientStreamRequest
requestData: "dGVzdCByZXNwb25zZQ=="
- request:
testName: client stream empty definition
testName: client-stream/empty-definition
service: connectrpc.conformance.v1.ConformanceService
method: ClientStream
streamType: STREAM_TYPE_CLIENT_STREAM
requestMessages:
- "@type": type.googleapis.com/connectrpc.conformance.v1.ClientStreamRequest
responseDefinition:
- request:
testName: client stream no definition
testName: client-stream/no-definition
service: connectrpc.conformance.v1.ConformanceService
method: ClientStream
streamType: STREAM_TYPE_CLIENT_STREAM
requestMessages:
- "@type": type.googleapis.com/connectrpc.conformance.v1.ClientStreamRequest
# Server Stream Tests ---------------------------------------------------------
- request:
testName: server stream success
testName: server-stream/success
service: connectrpc.conformance.v1.ConformanceService
method: ServerStream
streamType: STREAM_TYPE_SERVER_STREAM
Expand All @@ -92,7 +94,7 @@ testCases:
- name: x-custom-trailer
value: ["bing"]
- request:
testName: server stream no response
testName: server-stream/no-response
service: connectrpc.conformance.v1.ConformanceService
method: ServerStream
streamType: STREAM_TYPE_SERVER_STREAM
Expand All @@ -106,15 +108,15 @@ testCases:
- name: x-custom-trailer
value: ["bing"]
- request:
testName: server stream no definition
testName: server-stream/no-definition
service: connectrpc.conformance.v1.ConformanceService
method: ServerStream
streamType: STREAM_TYPE_SERVER_STREAM
requestMessages:
- "@type": type.googleapis.com/connectrpc.conformance.v1.ServerStreamRequest
# Bidi Stream Tests -----------------------------------------------------------
- request:
testName: bidi full duplex stream success
testName: bidi-stream/full-duplex/success
service: connectrpc.conformance.v1.ConformanceService
method: BidiStream
streamType: STREAM_TYPE_FULL_DUPLEX_BIDI_STREAM
Expand All @@ -137,7 +139,7 @@ testCases:
- "@type": type.googleapis.com/connectrpc.conformance.v1.BidiStreamRequest
requestData: "dGVzdCByZXNwb25zZQ=="
- request:
testName: bidi half duplex stream success
testName: bidi-stream/half-duplex/success
service: connectrpc.conformance.v1.ConformanceService
method: BidiStream
streamType: STREAM_TYPE_HALF_DUPLEX_BIDI_STREAM
Expand All @@ -161,7 +163,7 @@ testCases:
- request:
# Note there is no 'full duplex no definition set' test since that is
# logically equivalent to this test and is therefore covered here.
testName: bidi half duplex stream no definition set
testName: bidi-stream/half-duplex/no-definition
service: connectrpc.conformance.v1.ConformanceService
method: BidiStream
streamType: STREAM_TYPE_HALF_DUPLEX_BIDI_STREAM
Expand Down
27 changes: 14 additions & 13 deletions ...ormance/testsuites/data/cancellation.yaml → .../testsuites/data/client_cancellation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
name: Cancellation
# Cancellations only apply to clients under test
name: Client Cancellation
# The Cancellation suite tests stream cancellation
# and only applies to clients under test
mode: TEST_MODE_CLIENT
testCases:
# Client Stream Tests ---------------------------------------------------------
- request:
testName: client stream cancel before close send
testName: client-stream/cancel-before-close-send
service: connectrpc.conformance.v1.ConformanceService
method: ClientStream
streamType: STREAM_TYPE_CLIENT_STREAM
Expand All @@ -27,7 +28,7 @@ testCases:
error:
code: 1
- request:
testName: client stream cancel after close send
testName: client-stream/cancel-after-close-send
service: connectrpc.conformance.v1.ConformanceService
method: ClientStream
streamType: STREAM_TYPE_CLIENT_STREAM
Expand All @@ -52,7 +53,7 @@ testCases:
code: 1
# Server Stream Tests ---------------------------------------------------------
- request:
testName: server stream cancel after zero responses
testName: server-stream/cancel-after-zero-responses
service: connectrpc.conformance.v1.ConformanceService
method: ServerStream
streamType: STREAM_TYPE_SERVER_STREAM
Expand All @@ -76,7 +77,7 @@ testCases:
error:
code: 1
- request:
testName: server stream cancel after responses
testName: server-stream/cancel-after-responses
service: connectrpc.conformance.v1.ConformanceService
method: ServerStream
streamType: STREAM_TYPE_SERVER_STREAM
Expand Down Expand Up @@ -126,7 +127,7 @@ testCases:
error:
code: 1
- request:
testName: bidi full duplex cancel after responses
testName: bidi-stream/full-duplex/cancel-after-responses
service: connectrpc.conformance.v1.ConformanceService
method: BidiStream
streamType: STREAM_TYPE_FULL_DUPLEX_BIDI_STREAM
Expand Down Expand Up @@ -158,7 +159,7 @@ testCases:
error:
code: 1
- request:
testName: bidi full duplex cancel before close send
testName: bidi-stream/full-duplex/cancel-before-close-send
service: connectrpc.conformance.v1.ConformanceService
method: BidiStream
streamType: STREAM_TYPE_FULL_DUPLEX_BIDI_STREAM
Expand Down Expand Up @@ -193,7 +194,7 @@ testCases:
error:
code: 1
- request:
testName: bidi full duplex cancel after close send
testName: bidi-stream/full-duplex/cancel-after-close-send
service: connectrpc.conformance.v1.ConformanceService
method: BidiStream
streamType: STREAM_TYPE_FULL_DUPLEX_BIDI_STREAM
Expand Down Expand Up @@ -232,7 +233,7 @@ testCases:
error:
code: 1
- request:
testName: bidi half duplex cancel after zero responses
testName: bidi-stream/half-duplex/cancel-after-zero-responses
service: connectrpc.conformance.v1.ConformanceService
method: BidiStream
streamType: STREAM_TYPE_HALF_DUPLEX_BIDI_STREAM
Expand All @@ -252,7 +253,7 @@ testCases:
error:
code: 1
- request:
testName: bidi half duplex cancel after responses
testName: bidi-stream/half-duplex/cancel-after-responses
service: connectrpc.conformance.v1.ConformanceService
method: BidiStream
streamType: STREAM_TYPE_HALF_DUPLEX_BIDI_STREAM
Expand Down Expand Up @@ -284,7 +285,7 @@ testCases:
error:
code: 1
- request:
testName: bidi half duplex cancel before close send
testName: bidi-stream/half-duplex/cancel-before-close-send
service: connectrpc.conformance.v1.ConformanceService
method: BidiStream
streamType: STREAM_TYPE_HALF_DUPLEX_BIDI_STREAM
Expand All @@ -303,7 +304,7 @@ testCases:
error:
code: 1
- request:
testName: bidi half duplex cancel after close send
testName: bidi-stream/half-duplex/cancel-after-close-send
service: connectrpc.conformance.v1.ConformanceService
method: BidiStream
streamType: STREAM_TYPE_HALF_DUPLEX_BIDI_STREAM
Expand Down
29 changes: 16 additions & 13 deletions internal/app/connectconformance/testsuites/data/client_message_size.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
name: Client Message Size
# Test how a client handles various message sizes
mode: TEST_MODE_CLIENT
reliesOnMessageReceiveLimit: true
# We only test client message size interactions over the proto codec because
# the test runner calculates request size based on the binary format.
relevantCodecs:
- CODEC_PROTO
testCases:
# Unary Tests -----------------------------------------------------------------
- request:
testName: unary request equal to client limit
testName: unary/request-equal-to-client-limit
service: connectrpc.conformance.v1.ConformanceService
method: Unary
streamType: STREAM_TYPE_UNARY
Expand All @@ -17,7 +20,7 @@ testCases:
expandRequests:
- sizeRelativeToLimit: 0
- request:
testName: unary request exceeds client limit
testName: unary/request-exceeds-client-limit
service: connectrpc.conformance.v1.ConformanceService
method: Unary
streamType: STREAM_TYPE_UNARY
Expand All @@ -33,7 +36,7 @@ testCases:
code: 8
# Client Stream Tests ---------------------------------------------------------
- request:
testName: client stream all requests equal to client limit
testName: client-stream/all-requests-equal-to-client-limit
service: connectrpc.conformance.v1.ConformanceService
method: ClientStream
streamType: STREAM_TYPE_CLIENT_STREAM
Expand All @@ -47,7 +50,7 @@ testCases:
- sizeRelativeToLimit: 0
- sizeRelativeToLimit: 0
- request:
testName: client stream first request exceeds client limit
testName: client-stream/first-request-exceeds-client-limit
service: connectrpc.conformance.v1.ConformanceService
method: ClientStream
streamType: STREAM_TYPE_CLIENT_STREAM
Expand All @@ -65,7 +68,7 @@ testCases:
error:
code: 8
- request:
testName: client stream subsequent request exceeds client limit
testName: client-stream/subsequent-request-exceeds-client-limit
service: connectrpc.conformance.v1.ConformanceService
method: ClientStream
streamType: STREAM_TYPE_CLIENT_STREAM
Expand All @@ -84,7 +87,7 @@ testCases:
code: 8
# Server Stream Tests ---------------------------------------------------------
- request:
testName: server stream request equal to client limit
testName: server-stream/request-equal-to-client-limit
service: connectrpc.conformance.v1.ConformanceService
method: ServerStream
streamType: STREAM_TYPE_SERVER_STREAM
Expand All @@ -97,7 +100,7 @@ testCases:
expandRequests:
- sizeRelativeToLimit: 0
- request:
testName: server stream request exceeds client limit
testName: server-stream/request-exceeds-client-limit
service: connectrpc.conformance.v1.ConformanceService
method: ServerStream
streamType: STREAM_TYPE_SERVER_STREAM
Expand All @@ -115,7 +118,7 @@ testCases:
code: 8
# Bidi Stream Tests -----------------------------------------------------------
- request:
testName: bidi half duplex all requests equal to client limit
testName: bidi-stream/half-duplex/all-requests-equal-to-client-limit
service: connectrpc.conformance.v1.ConformanceService
method: BidiStream
streamType: STREAM_TYPE_HALF_DUPLEX_BIDI_STREAM
Expand All @@ -131,7 +134,7 @@ testCases:
- sizeRelativeToLimit: 0
- sizeRelativeToLimit: 0
- request:
testName: bidi half duplex first request exceeds client limit
testName: bidi-stream/half-duplex/first-request-exceeds-client-limit
service: connectrpc.conformance.v1.ConformanceService
method: BidiStream
streamType: STREAM_TYPE_HALF_DUPLEX_BIDI_STREAM
Expand All @@ -153,7 +156,7 @@ testCases:
error:
code: 8
- request:
testName: bidi half duplex subsequent request exceeds client limit
testName: bidi-stream/half-duplex/subsequent-request-exceeds-client-limit
service: connectrpc.conformance.v1.ConformanceService
method: BidiStream
streamType: STREAM_TYPE_HALF_DUPLEX_BIDI_STREAM
Expand All @@ -175,7 +178,7 @@ testCases:
error:
code: 8
- request:
testName: bidi full duplex all requests equal to client limit
testName: bidi-stream/full-duplex/all-requests-equal-to-client-limit
service: connectrpc.conformance.v1.ConformanceService
method: BidiStream
streamType: STREAM_TYPE_FULL_DUPLEX_BIDI_STREAM
Expand All @@ -192,7 +195,7 @@ testCases:
- sizeRelativeToLimit: 0
- sizeRelativeToLimit: 0
- request:
testName: bidi full duplex first request exceeds client limit
testName: bidi-stream/full-duplex/first-request-exceeds-client-limit
service: connectrpc.conformance.v1.ConformanceService
method: BidiStream
streamType: STREAM_TYPE_FULL_DUPLEX_BIDI_STREAM
Expand All @@ -216,7 +219,7 @@ testCases:
# TODO - Need a way to populate the expected response payload because the test
# library padded it with size and we don't know what it looks like here.
# - request:
# testName: bidi full duplex subsequent request exceeds client limit
# testName: bidi-stream/full-duplex/subsequent-request-exceeds-client-limit
# service: connectrpc.conformance.v1.ConformanceService
# method: BidiStream
# streamType: STREAM_TYPE_FULL_DUPLEX_BIDI_STREAM
Expand Down
Loading