Rename tests and test files #786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 10, 2024 09:27
jhump
approved these changes
Feb 12, 2024
Member
jhump
left a comment
There was a problem hiding this comment.
Some suggestions to further simplify: I don't think it's necessary to state the stream type for every test case since, for many tests, the stream type is not relevant or is implied by the test suite (for example, Connect GET can only ever work with unary). Other than that LGTM.
internal/app/connectconformance/testsuites/data/connect_client_code_to_http_code.yaml
Show resolved
Hide resolved
internal/app/connectconformance/testsuites/data/connect_client_http_to_connect_code.yaml
Outdated
Show resolved
Hide resolved
internal/app/connectconformance/testsuites/data/connect_idempotency.yaml
Outdated
Show resolved
Hide resolved
internal/app/connectconformance/testsuites/data/tls-client-certs.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Joshua Humphries <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames all tests and some test files to adhere to a loose naming convention:
connect_idempotency.yaml){stream type}/{optional description}{stream type}/{[full | half] duplex}/{optional description}This allows a lot of flexibility over ignoring tests in
known_failingfiles, as well as targeting specific types of tests from the command line (i.e.server-stream/*to run all server stream tests).