[storage/index] fix + unit test for cursor update bug #1152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ef249ae to
902b464
Compare
902b464 to
9e46d21
Compare
dnkolegov-ar
approved these changes
Jun 25, 2025
|
Replacing with #1155 |
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #1152 +/- ##
==========================================
- Coverage 91.03% 91.01% -0.02%
==========================================
Files 215 215
Lines 57425 57440 +15
==========================================
+ Hits 52276 52281 +5
- Misses 5149 5159 +10
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping a cursor in a middle of an iteration was resulting in dangling items. This PR will re-attach any dangling items in drop(). Unfortunately this means every cursor opened against an entry must end up traversing the entire list, even if the desired item is found right away. It also changes how items end up ordered after each cursor lifecycle.
Also makes every Index test have a "test_index" prefix.