[storage/index] Fix Middle Mutate Case #1155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-ogrady
commented
Jun 25, 2025
| /// Pushes a `Record` to the end of `past`. | ||
| /// | ||
| /// If the record has a `next`, this function cannot be called again. | ||
| fn past_push(&mut self, mut next: Box<Record<V>>) { |
There was a problem hiding this comment.
This refactored past_push has the convenient byproduct of retaining the insertion order. I considered special casing next w/list insertion but seemed cleaner to just reduce the logic to one pattern.
There was a problem hiding this comment.
I find this simpler than the reverse list we were creating during iteration but it does use unsafe.
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the middle mutate case in the storage index by updating the record linking logic and adjusting the test expectations accordingly.
- Updated the Cursor struct with new fields (past_tail and past_pushed_list) and refactored the past_push method to support controlled list mutation.
- Modified tests in mod.rs to reflect the new ordering of records and standardized test function naming.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| storage/src/index/storage.rs | Introduces new raw pointer field and updates past_push logic. |
| storage/src/index/mod.rs | Adjusts test expectations and renames test functions uniformly. |
Comments suppressed due to low confidence (2)
storage/src/index/storage.rs:124
- Consider adding a comment within the unsafe block to document the invariants that guarantee the validity of the raw pointer 'past_tail' to assist future maintainability and safety reviews.
unsafe {
storage/src/index/mod.rs:79
- The updated expected order of elements indicates a change in the underlying logic; consider adding a note in the test documentation explaining the rationale behind the new order.
assert_eq!(index.get(key).copied().collect::<Vec<_>>(), vec![1, 4, 2]);
|
Ran |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #1155 +/- ##
=======================================
Coverage 91.03% 91.03%
=======================================
Files 215 215
Lines 57425 57434 +9
=======================================
+ Hits 52276 52285 +9
Misses 5149 5149
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative: #1152