Skip to content

[runtime] change single_issuer config default to false #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025
Merged

[runtime] change single_issuer config default to false #1035

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
437fc91
change single_issuer config default to false
danlaine May 30, 2025
87452b0
appease cargo doc
danlaine May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion runtime/src/iouring/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@ pub struct Config {
/// If true, use IOPOLL mode.
pub io_poll: bool,
/// If true, use single issuer mode.
/// Warning: when enabled, user must guarantee that the same thread
/// that creates the io_uring instance is the only thread that submits
/// work to it. Since the `run` event loop is a future that may move
/// between threads, this means in practice that `single_issuer` should
/// only be used in a single-threaded context.
/// See IORING_SETUP_SINGLE_ISSUER in <https://man7.org/linux/man-pages/man2/io_uring_setup.2.html>.
pub single_issuer: bool,
/// In the io_uring event loop (`run`), wait at most this long for a new
/// completion before checking for new work to submit to the io_ring.
Expand Down Expand Up @@ -70,7 +76,7 @@ impl Default for Config {
Self {
size: 128,
io_poll: false,
single_issuer: true,
single_issuer: false,
force_poll: None,
op_timeout: None,
shutdown_timeout: None,
Expand Down
Loading