Skip to content

Conversation

danlaine
Copy link
Collaborator

@danlaine danlaine commented May 30, 2025

Future Work: #1037

@danlaine danlaine self-assigned this May 30, 2025
@danlaine danlaine requested a review from patrick-ogrady May 30, 2025 21:25
@patrick-ogrady
Copy link
Contributor

I "think" we could set single-issuer to explicitly be true in network::iouring and storage::iouring (as we run in a dedicated thread)?

@patrick-ogrady patrick-ogrady merged commit 259675f into main May 30, 2025
15 checks passed
@patrick-ogrady patrick-ogrady deleted the danlaine/iouring-change-default branch May 30, 2025 23:50
Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.98%. Comparing base (e95b043) to head (87452b0).
Report is 2 commits behind head on main.

@@           Coverage Diff           @@
##             main    #1035   +/-   ##
=======================================
  Coverage   90.97%   90.98%           
=======================================
  Files         192      192           
  Lines       54092    54092           
=======================================
+ Hits        49209    49214    +5     
+ Misses       4883     4878    -5     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e95b043...87452b0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants