Bump the all group across 1 directory with 10 updates #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps the all group with 7 updates in the / directory: | Package | From | To | | --- | --- | --- | | [github.com/cert-manager/cert-manager](https://github.com/cert-manager/cert-manager) | `1.17.1` | `1.17.2` | | [k8s.io/api](https://github.com/kubernetes/api) | `0.32.3` | `0.33.0` | | [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.32.3` | `0.33.0` | | [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime) | `0.32.3` | `0.33.0` | | [k8s.io/kube-aggregator](https://github.com/kubernetes/kube-aggregator) | `0.32.3` | `0.33.0` | | [k8s.io/kubectl](https://github.com/kubernetes/kubectl) | `0.32.3` | `0.33.0` | | [sigs.k8s.io/gateway-api](https://github.com/kubernetes-sigs/gateway-api) | `1.2.1` | `1.3.0` | Updates `github.com/cert-manager/cert-manager` from 1.17.1 to 1.17.2 - [Release notes](https://github.com/cert-manager/cert-manager/releases) - [Changelog](https://github.com/cert-manager/cert-manager/blob/master/RELEASE.md) - [Commits](cert-manager/cert-manager@v1.17.1...v1.17.2) Updates `k8s.io/api` from 0.32.3 to 0.33.0 - [Commits](kubernetes/api@v0.32.3...v0.33.0) Updates `k8s.io/apiextensions-apiserver` from 0.32.3 to 0.33.0 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](kubernetes/apiextensions-apiserver@v0.32.3...v0.33.0) Updates `k8s.io/apimachinery` from 0.32.3 to 0.33.0 - [Commits](kubernetes/apimachinery@v0.32.3...v0.33.0) Updates `k8s.io/cli-runtime` from 0.32.3 to 0.33.0 - [Commits](kubernetes/cli-runtime@v0.32.3...v0.33.0) Updates `k8s.io/client-go` from 0.32.3 to 0.33.0 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.32.3...v0.33.0) Updates `k8s.io/component-base` from 0.32.3 to 0.33.0 - [Commits](kubernetes/component-base@v0.32.3...v0.33.0) Updates `k8s.io/kube-aggregator` from 0.32.3 to 0.33.0 - [Commits](kubernetes/kube-aggregator@v0.32.3...v0.33.0) Updates `k8s.io/kubectl` from 0.32.3 to 0.33.0 - [Commits](kubernetes/kubectl@v0.32.3...v0.33.0) Updates `sigs.k8s.io/gateway-api` from 1.2.1 to 1.3.0 - [Release notes](https://github.com/kubernetes-sigs/gateway-api/releases) - [Changelog](https://github.com/kubernetes-sigs/gateway-api/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/gateway-api@v1.2.1...v1.3.0) --- updated-dependencies: - dependency-name: github.com/cert-manager/cert-manager dependency-version: 1.17.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all - dependency-name: k8s.io/api dependency-version: 0.33.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all - dependency-name: k8s.io/apiextensions-apiserver dependency-version: 0.33.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all - dependency-name: k8s.io/apimachinery dependency-version: 0.33.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all - dependency-name: k8s.io/cli-runtime dependency-version: 0.33.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all - dependency-name: k8s.io/client-go dependency-version: 0.33.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all - dependency-name: k8s.io/component-base dependency-version: 0.33.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all - dependency-name: k8s.io/kube-aggregator dependency-version: 0.33.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all - dependency-name: k8s.io/kubectl dependency-version: 0.33.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all - dependency-name: sigs.k8s.io/gateway-api dependency-version: 1.3.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all ... Signed-off-by: dependabot[bot] <[email protected]>
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Signed-off-by: Richard Wall <[email protected]>
* staticcheck: Use of deprecated functions * usetesting: Use new testing helper functions Signed-off-by: Richard Wall <[email protected]>
c6daa39 to
849d06d
Compare
wallrj
reviewed
Apr 25, 2025
| fuzz "github.com/google/gofuzz" | ||
| apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1" | ||
| runtimeserializer "k8s.io/apimachinery/pkg/runtime/serializer" | ||
| "sigs.k8s.io/randfill" |
There was a problem hiding this comment.
See https://github.com/kubernetes-sigs/randfill
This is a fork of github.com/google/gofuzz, which was archived.
| func(s *acme.Order, c fuzz.Continue) { | ||
| c.FuzzNoCustom(s) // fuzz self without calling this function again | ||
| func(s *acme.Order, c randfill.Continue) { | ||
| c.FillNoCustom(s) // fuzz self without calling this function again |
There was a problem hiding this comment.
Fixes the following panic:
=== FAIL: pkg/convert/internal/apis/certmanager/install TestRoundTripTypes (0.00s)
panic: Filler.Funcs: customFuncs' second argument must be a randfill.Continue [recovered]
panic: Filler.Funcs: customFuncs' second argument must be a randfill.Continue
goroutine 20 [running]:
testing.tRunner.func1.2({0xde37c0, 0x10c11e0})
/home/richard/projects/cert-manager/cmctl/_bin/tools/goroot/src/testing/testing.go:1734 +0x21c
testing.tRunner.func1()
/home/richard/projects/cert-manager/cmctl/_bin/tools/goroot/src/testing/testing.go:1737 +0x35e
panic({0xde37c0?, 0x10c11e0?})
/home/richard/projects/cert-manager/cmctl/_bin/tools/goroot/src/runtime/panic.go:792 +0x132
sigs.k8s.io/randfill.(*Filler).Funcs(0xc00012c4e0, {0xc000105880, 0x13, 0xc0001056c0?})
/home/richard/projects/pkg/mod/sigs.k8s.io/[email protected]/randfill.go:145 +0x2b8
k8s.io/apimachinery/pkg/api/apitesting/fuzzer.FuzzerFor(0xc00016fed0, {0x10c5430, 0xc00024d500}, {0xc0002d2000, {0x10c3d60, 0xc00013f158}, {0xc0001056c0, 0x3, 0x4}, {0x10c94f0, ...}})
/home/richard/projects/pkg/mod/k8s.io/[email protected]/pkg/api/apitesting/fuzzer/fuzzer.go:40 +0xcd
k8s.io/apimachinery/pkg/api/apitesting/roundtrip.RoundTripTestForScheme(0xc000105340, 0xc0002d2000, 0xfd33c0)
/home/richard/projects/pkg/mod/k8s.io/[email protected]/pkg/api/apitesting/roundtrip/roundtrip.go:59 +0x1a5
k8s.io/apimachinery/pkg/api/apitesting/roundtrip.RoundTripTestForAPIGroup(0xc000105340, 0xfd1fd0, 0xfd33c0)
/home/richard/projects/pkg/mod/k8s.io/[email protected]/pkg/api/apitesting/roundtrip/roundtrip.go:53 +0x48
github.com/cert-manager/cmctl/v2/pkg/convert/internal/apis/certmanager/install.TestRoundTripTypes(0xc000105340?)
/home/richard/projects/cert-manager/cmctl/pkg/convert/internal/apis/certmanager/install/roundtrip_test.go:28 +0x25
testing.tRunner(0xc000105340, 0xfd1e98)
/home/richard/projects/cert-manager/cmctl/_bin/tools/goroot/src/testing/testing.go:1792 +0xf4
created by testing.(*T).Run in goroutine 1
/home/richard/projects/cert-manager/cmctl/_bin/tools/goroot/src/testing/testing.go:1851 +0x413
Signed-off-by: Richard Wall <[email protected]>
849d06d to
49dad09
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates various dependency and context usage throughout test and utility files by replacing context.Background() with t.Context() and similar improvements, ensuring tests use the proper test context.
- Consistently replaces context.Background() with t.Context() for better integration with test lifecycles.
- Removes redundant temporary directory management in favor of t.TempDir() in tests.
- Updates fuzzer functions to use the new randfill.Continue syntax from the previously used gofuzz.
Reviewed Changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/integration/migrate/ctl_upgrade_migrate_test.go | Updated context usage in upgrade migration tests. |
| test/integration/framework/helpers.go | Adjusted context propagation in informers and controller helper. |
| test/integration/ctl_uninstall_test.go | Changed context creation for uninstall tests. |
| test/integration/ctl_status_certificate_test.go | Updated context usage in status certificate test. |
| test/integration/ctl_renew_test.go | Replaced context.Background() with t.Context() in renewal test. |
| test/integration/ctl_install_test.go | Updated context usage in installation test. |
| test/integration/ctl_create_cr_test.go | Switched to use t.TempDir() and t.Chdir() for file path setup. |
| test/integration/ctl_convert_test.go | Updated context usage in conversion tests. |
| pkg/status/certificate/certificate.go | Switched to using SearchWithContext() for event queries. |
| pkg/renew/renew_test.go | Passed t.Context() to the renew command instead of context.TODO(). |
| pkg/inspect/secret/secret_test.go | Updated context usage in secret inspection tests. |
| pkg/create/certificaterequest/certificaterequest_test.go | Updated context passed to CR creation tests. |
| pkg/convert/internal/apis/certmanager/fuzzer/fuzzer.go | Replaced fuzz.Continue with randfill.Continue according to new conventions. |
| pkg/convert/internal/apis/acme/fuzzer/fuzzer.go | Replaced fuzz.Continue with randfill.Continue. |
| internal/versionchecker/test/versionchecker_test.go | Updated context usage in version checking test. |
| internal/util/signal_test.go & internal/util/exit_test.go | Updated context usage for exit handler tests. |
Files not reviewed (1)
- go.mod: Language not supported
erikgb
reviewed
Apr 25, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: erikgb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the all group with 7 updates in the / directory:
1.17.11.17.20.32.30.33.00.32.30.33.00.32.30.33.00.32.30.33.00.32.30.33.01.2.11.3.0Updates
github.com/cert-manager/cert-managerfrom 1.17.1 to 1.17.2Release notes
Sourced from github.com/cert-manager/cert-manager's releases.
Commits
f3ffb86Merge pull request #7703 from wallrj/release-1.17-trivy-275366d4make generate-licenses1792adbmake go-tidy788bfc8go get golang.org/x/[email protected]c02bec7Merge pull request #7701 from wallrj/release-1.17-trivyd8bb946Merge pull request #7704 from wallrj/release-1.17-bump-base-images8e06936make update-base-images05fc833make go-tidy5d2b5bf_bin/tools/go get [email protected]12a41eeBump go to v1.23.8Updates
k8s.io/apifrom 0.32.3 to 0.33.0Commits
82c0029Update dependencies to v0.33.0 tag16cedc7Merge pull request #131088 from atiratree/rename-terminating-replicas-fgdc88679Merge pull request #131103 from ahrtr/etcd_sdk_202503284a456a2bump etcd 3.5.21 sdk96e38c9rename DeploymentPodReplacementPolicy FG to DeploymentReplicaSetTerminatingRe...c21a017Merge pull request #129970 from mortent/AddResourceV1beta2APId0673dbRun make update118546dMerge pull request #130556 from sreeram-venkitesh/kep-4960-container-stop-sig...f9401a3Merge pull request #130797 from jm-franc/configurable-tolerance9b3e544Generated UPDATE_COMPATIBILITY_FIXTURE_DATAUpdates
k8s.io/apiextensions-apiserverfrom 0.32.3 to 0.33.0Commits
1b7ab0fUpdate dependencies to v0.33.0 tagc066cbeMerge remote-tracking branch 'origin/master' into release-1.3308c3d2fMove to released version of prometheus/client_golang v1.22.0 from rc.07c1033efix narrow spaces of %e for x/net bumpcdf67ddbump etcd 3.5.21 sdkb8b1528Merge pull request #129872 from seans3/websocket-https-proxyd5c7de8Websocket HTTPS proxy supportde39b8dMerge pull request #130899 from serathius/watchcache-error7022eabMerge pull request #130020 from mozillazg/patch-3718a2c7Merge pull request #130906 from serathius/streaming-validationUpdates
k8s.io/apimachineryfrom 0.32.3 to 0.33.0Commits
955939fbump etcd 3.5.21 sdke8a77bdMerge pull request #130910 from googs1025/fix/datarace7e8c77eMerge pull request #130906 from serathius/streaming-validation27fd396flake: fix data race for func TestBackoff_Step8bcc6f1Update kube-openapi and integrate streaming tags validation6ce776cMerge pull request #130857 from thockin/kk_small_vg_diffsf2c94d6Comment on origin and JSON schemab63ba07Use origin in validateFalse's own testbeddba4Use test.Helper in helper funcseaf4038Merge pull request #130354 from siyuanfoundation/forward-apiUpdates
k8s.io/cli-runtimefrom 0.32.3 to 0.33.0Commits
46ca2a9Update dependencies to v0.33.0 tag2811321bump etcd 3.5.21 sdkb44307fMerge pull request #129872 from seans3/websocket-https-proxyf7c023cWebsocket HTTPS proxy support178adecMerge pull request #130906 from serathius/streaming-validation1e2dc5cUpdate kube-openapi and integrate streaming tags validation7d637a3Merge pull request #130555 from thockin/k_k_randfill67be32dVendor randfill2dc7b80Merge pull request #130569 from dims/update-to-latest-cadvisor-v0.52.0a4e93f9update to v1.22.0-rc.0Updates
k8s.io/client-gofrom 0.32.3 to 0.33.0Commits
3aa3c77Update dependencies to v0.33.0 tagecbbb06bump etcd 3.5.21 sdk2086688Merge pull request #129970 from mortent/AddResourceV1beta2APIdba34c7Run make updatee359642Merge pull request #130556 from sreeram-venkitesh/kep-4960-container-stop-sig...3bf0a05Merge pull request #130797 from jm-franc/configurable-tolerance7a03a3bGenerated files1676bebRefresh autogenerated files following the configurable tolerance updates.387edb8Merge pull request #130967 from aojea/listers21dc3b4benchmark to show inefficient linear search lookupUpdates
k8s.io/component-basefrom 0.32.3 to 0.33.0Commits
07e241dUpdate dependencies to v0.33.0 tag8e0b9e8Merge remote-tracking branch 'origin/master' into release-1.3321643b0Move to released version of prometheus/client_golang v1.22.0 from rc.0316f3e2bump etcd 3.5.21 sdkf52df19Merge pull request #129872 from seans3/websocket-https-proxycc34cc0Merge pull request #130916 from richabanker/oidc-flags-v34906cf7Merge pull request #130930 from siyuanfoundation/helpfdef30fMerge pull request #130447 from pohly/dra-device-taints8618ec8Merge pull request #130079 from yongruilin/compatibility-remove-reset1565ae1chore: update emulation version help msg.Updates
k8s.io/kube-aggregatorfrom 0.32.3 to 0.33.0Commits
dd8452dUpdate dependencies to v0.33.0 tag7e0b78bMerge remote-tracking branch 'origin/master' into release-1.33ad05af7Move to released version of prometheus/client_golang v1.22.0 from rc.096da1d8bump etcd 3.5.21 sdk6d563d7Merge pull request #129872 from seans3/websocket-https-proxyfd4539cWebsocket HTTPS proxy support6726892Merge pull request #130906 from serathius/streaming-validation6affbe5Update kube-openapi and integrate streaming tags validationab13abfMerge pull request #130560 from stlaz/remote-uid-config-betac6cc1a4bump RemoteRequestHeaderUID featuregate to Beta, on by defaultUpdates
k8s.io/kubectlfrom 0.32.3 to 0.33.0Commits
ee99ea3Update dependencies to v0.33.0 tagce68e04Merge remote-tracking branch 'origin/master' into release-1.3305423b2Move to released version of prometheus/client_golang v1.22.0 from rc.0dc53668bump etcd 3.5.21 sdk5366de0Merge pull request #129872 from seans3/websocket-https-proxy7577f36Merge pull request #130880 from tallclair/ippr-allocatablef38b1deConsider AllocatableResources when computing pod requests0d5516dMerge pull request #130033 from ardaguclu/completion-use-restclientgetter5cbdedbkubectl debug: Display a warning message that the debug container's capabilit...6203603Merge pull request #130906 from serathius/streaming-validationUpdates
sigs.k8s.io/gateway-apifrom 1.2.1 to 1.3.0Release notes
Sourced from sigs.k8s.io/gateway-api's releases.
... (truncated)
Commits
40be951Adding changelog for v1.3 (#3765)cd09161Add 1.3 release team and update relevant GEPs (#3764)4d8c92cfix typo in BudgetDetails (#3762)efec20ddocs: add release managment to RELEASE.md (#3726)b6d2f2cSimplify hack/build-install-yaml.sh (#3754)97f1dcfChangelog for v1.3.0-rc.2 (#3749)75aed66Requiring Port number on ListenerSet Listener (#3753)1bf3f2cconformance: do not log when we do not sleep (#3752)1ef70ddDoc update to kgateway (#3737)7030481Removing "None" as option for Route Namespaces (#3748)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions