Skip to content

fix: secret tests were failing on osx due to difference in error message format #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

fix: secret tests were failing on osx due to difference in error message format #218

merged 1 commit into from
Apr 29, 2025

Conversation

ThatsMrTalbot
Copy link
Contributor

No description provided.

@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 23, 2025
inteon
inteon reviewed Apr 25, 2025
View reviewed changes
@cert-manager-prow cert-manager-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2025
wallrj
wallrj requested changes Apr 29, 2025
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThatsMrTalbot Thanks.

Suggest reverting the dependency updates...some of which have been done in #221

Make this PR just about fixing the unit-tests on macos.

Fixes: #203

@ThatsMrTalbot ThatsMrTalbot force-pushed the chore/update-dependencies branch from 7dfd053 to 6d29414 Compare April 29, 2025 12:57
@cert-manager-prow cert-manager-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 29, 2025
@ThatsMrTalbot ThatsMrTalbot changed the title chore: update all dependencies and fix tests on macos fix: secret tests were failing on osx due to difference in error message format Apr 29, 2025
@ThatsMrTalbot ThatsMrTalbot requested a review from wallrj April 29, 2025 12:58
@ThatsMrTalbot
Copy link
Contributor Author

@ThatsMrTalbot Thanks.

Suggest reverting the dependency updates...some of which have been done in #221

Make this PR just about fixing the unit-tests on macos.

Fixes: #203

Now just contains the test fixes

@wallrj wallrj linked an issue Apr 29, 2025 that may be closed by this pull request
Unit tests are failing on Go 1.24.1 #203
Closed
wallrj
wallrj approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ThatsMrTalbot

Tests are passing in CI and on my Linux laptop and you've tested on your Mac.

$ make test-unit
...

DONE 270 tests in 26.698s

$ make test-integration
...
DONE 46 tests in 101.957s

/approve
/lgtm

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2025
@cert-manager-prow cert-manager-prow bot merged commit b222de3 into cert-manager:main Apr 29, 2025
5 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Apr 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inteon inteon inteon left review comments

@wallrj wallrj wallrj approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unit tests are failing on Go 1.24.1

3 participants

@ThatsMrTalbot @wallrj @inteon