feat: Add public OOO notes display on booking pages #25471

dhairyashiil · 2025-11-29T14:37:52Z

Video:

Screen.Recording.2025-11-29.at.10.00.57.PM.mov

tooltip

Screen.Recording.2025-11-29.at.10.04.31.PM.mov

team ooo

Screen.Recording.2025-11-29.at.10.56.30.PM.mov

What does this PR do?

Adds the ability to display Out of Office (OOO) notes publicly on booking pages with a privacy toggle. This feature improves transparency and communication when users are unavailable.

Changes

Database Schema

Added showNotePublicly boolean field to OutOfOfficeEntry model (default: false for backward compatibility)
Created and applied database migration

Backend (tRPC)

Updated outOfOfficeCreateOrUpdate handler to accept and save showNotePublicly field
Updated Zod schema validation to include showNotePublicly as optional boolean
Modified OOO repository methods to select and return notes and showNotePublicly fields
Updated getUserAvailability to propagate OOO notes and visibility through the data flow
Enhanced slot generation logic to include notes when publicly visible

Frontend - Settings UI

Added "Show note publicly" toggle to Create/Edit OOO Entry modal
Toggle positioned next to "Notes" label following Booking Questions UI pattern
Shows "Hidden" badge when toggle is OFF, no text when ON
Toggle always visible (not dependent on note content)
Fixed bug where toggle state wasn't properly loaded when editing existing entries

Frontend - Booking Page

Display OOO message on booking page when showNotePublicly is enabled
Message shows before redirect information with "OOO Message:" label
Only message text is italicized, not the label
OOO dates are now selectable even without redirect configured
Redirect button only shows when team member is assigned
Added scrollable container for long notes (max-height: 120px) to prevent UI overflow
Hide 12h/24h time format toggle when viewing OOO dates (optimization: O(1) check)

Use Cases

Scenario 1: OOO with Redirect

User selects OOO date on calendar
Sees OOO emoji, user name, message, and redirect text
Redirect button displayed to book with team member

Scenario 2: OOO without Redirect

User selects OOO date on calendar
Sees OOO emoji, user name, and message (if public)
No redirect button shown
Cannot book time slots (blocked)

vercel · 2025-11-29T14:38:01Z

@dhairyashiil is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

cubic-dev-ai

2 issues found across 16 files

Prompt for AI agents (all 2 issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/features/availability/lib/getUserAvailability.ts">

<violation number="1" location="packages/features/availability/lib/getUserAvailability.ts:650">
`notes` should only be included in the availability payload when `showNotePublicly` is true; otherwise private notes are leaked to the client despite the privacy toggle.</violation>
</file>

<file name="packages/features/bookings/Booker/components/AvailableTimeSlots.tsx">

<violation number="1" location="packages/features/bookings/Booker/components/AvailableTimeSlots.tsx:196">
`isOOODay` only inspects the first slot, so the time-format toggle disappears even when later slots are bookable on partially OOO days.</violation>
</file>

_{Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR}

packages/features/availability/lib/getUserAvailability.ts

packages/features/bookings/Booker/components/AvailableTimeSlots.tsx

…rough client-side payloads

cubic-dev-ai

1 issue found across 16 files

Prompt for AI agents (all 1 issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/trpc/server/routers/viewer/ooo/outOfOfficeCreateOrUpdate.handler.ts">

<violation number="1" location="packages/trpc/server/routers/viewer/ooo/outOfOfficeCreateOrUpdate.handler.ts:182">
Updating an existing OOO entry without explicitly providing `showNotePublicly` now forces the value back to `false`, so public notes are unintentionally hidden whenever older clients submit updates that omit the new field. Preserve the prior value instead of defaulting to `false` during updates.</violation>
</file>

_{Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR}

packages/trpc/server/routers/viewer/ooo/outOfOfficeCreateOrUpdate.handler.ts

CarinaWolli

Remove "OOO message:"

Instead of the toggle add a checkbox with "Show note on public booking page"

Didn't test, but this also needs to show when there is no redirect

…ing-page

- Replace Switch with Checkbox for "show note publicly" option - Remove "OOO Message:" prefix from displayed notes on booking page - Update i18n text to "Show note on public booking page" - Remove unused ooo_message i18n key

dhairyashiil · 2025-12-10T17:46:27Z

done @CarinaWolli , here is the updated video (also shown the case where this work when there is no redirect)

Screen.Recording.2025-12-10.at.11.12.52.PM.mov

cubic-dev-ai

1 issue found across 16 files

Prompt for AI agents (all 1 issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/features/settings/outOfOffice/CreateOrEditOutOfOfficeModal.tsx">

<violation number="1" location="packages/features/settings/outOfOffice/CreateOrEditOutOfOfficeModal.tsx:361">
P2: Accessibility issue: The `&lt;label&gt;` element uses `onClick` instead of proper `htmlFor` association. Screen readers won&#39;t announce the relationship between the label and checkbox. Consider adding an `id` to the Checkbox and using `htmlFor` on the label, or use the `CheckboxField` component which has built-in label support.</violation>
</file>

_{Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR}

packages/features/settings/outOfOffice/CreateOrEditOutOfOfficeModal.tsx

CarinaWolli · 2025-12-11T08:46:10Z

packages/features/calendars/DatePicker.tsx


-    const disabled = away ? !oooInfo?.toUser : isNextMonth ? !hasAvailableSlots : !included || excluded;
+    // Allow selecting OOO dates even without redirect - they'll see the OOO message
+    const disabled = away ? false : isNextMonth ? !hasAvailableSlots : !included || excluded;


needs to stay disabled when OOO note is not public

done

Screen.Recording.2025-12-11.at.2.33.43.PM.mov

…-booking-page

cubic-dev-ai

No issues found across 16 files

CarinaWolli

Nice work, looks great 👏🏻

emrysal

Approved!

dhairyashiil added 4 commits November 29, 2025 19:34

feat: ooo message on booking page

a27d003

make ooo days selectable even when no redirect booking

8242a20

handle long notes

1aa3039

remove unused i18n key

98d5f69

dhairyashiil requested a review from a team as a code owner November 29, 2025 14:37

pull-request-size bot added the size/L label Nov 29, 2025

graphite-app bot added the community Created by Linear-GitHub Sync label Nov 29, 2025

github-actions bot added the ❗️ migrations contains migration files label Nov 29, 2025

keithwillcode added the community-interns The team responsible for reviewing, testing and shipping low/medium community PRs label Nov 29, 2025

cubic-dev-ai bot reviewed Nov 29, 2025

View reviewed changes

packages/features/availability/lib/getUserAvailability.ts Outdated Show resolved Hide resolved

packages/features/bookings/Booker/components/AvailableTimeSlots.tsx Show resolved Hide resolved

Private notes stay private on the server, No accidental data leaks th…

db78e78

…rough client-side payloads

dhairyashiil marked this pull request as draft November 29, 2025 15:09

dhairyashiil marked this pull request as ready for review November 29, 2025 16:36

cubic-dev-ai bot reviewed Nov 29, 2025

View reviewed changes

packages/trpc/server/routers/viewer/ooo/outOfOfficeCreateOrUpdate.handler.ts Show resolved Hide resolved

address cubics comments

56fbcc5

CarinaWolli requested changes Dec 5, 2025

View reviewed changes

github-actions bot marked this pull request as draft December 5, 2025 15:04

dhairyashiil added 2 commits December 10, 2025 20:30

Merge remote-tracking branch 'upstream' into feat/ooo-message-on-book…

679f5d3

…ing-page

fix: replace toggle with checkbox for OOO note visibility

83d35ab

- Replace Switch with Checkbox for "show note publicly" option - Remove "OOO Message:" prefix from displayed notes on booking page - Update i18n text to "Show note on public booking page" - Remove unused ooo_message i18n key

dhairyashiil marked this pull request as ready for review December 10, 2025 17:45

cubic-dev-ai bot reviewed Dec 10, 2025

View reviewed changes

packages/features/settings/outOfOffice/CreateOrEditOutOfOfficeModal.tsx Outdated Show resolved Hide resolved

fix the accessibility issue by using proper htmlFor and id association

529b1b9

CarinaWolli requested changes Dec 11, 2025

View reviewed changes

github-actions bot marked this pull request as draft December 11, 2025 08:47

dhairyashiil added 2 commits December 11, 2025 14:27

Merge remote-tracking branch 'upstream/main' into feat/ooo-message-on…

0d1a779

…-booking-page

only allow selecting OOO dates when the note is public

285e378

dhairyashiil marked this pull request as ready for review December 11, 2025 09:05

cubic-dev-ai bot reviewed Dec 11, 2025

View reviewed changes

dhairyashiil requested a review from CarinaWolli December 11, 2025 09:34

CarinaWolli approved these changes Dec 11, 2025

View reviewed changes

CarinaWolli enabled auto-merge (squash) December 11, 2025 09:51

dhairyashiil added the ready-for-e2e label Dec 11, 2025

emrysal approved these changes Dec 11, 2025

View reviewed changes

CarinaWolli merged commit 26b4385 into calcom:main Dec 11, 2025
80 of 91 checks passed

feat: Add public OOO notes display on booking pages #25471

feat: Add public OOO notes display on booking pages #25471

Conversation

dhairyashiil commented Nov 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Video:

What does this PR do?

Changes

Database Schema

Backend (tRPC)

Frontend - Settings UI

Frontend - Booking Page

Use Cases

Scenario 1: OOO with Redirect

Scenario 2: OOO without Redirect

Uh oh!

vercel bot commented Nov 29, 2025

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CarinaWolli left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dhairyashiil commented Dec 10, 2025

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CarinaWolli Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

dhairyashiil Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

CarinaWolli left a comment

Choose a reason for hiding this comment

Uh oh!

emrysal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dhairyashiil commented Nov 29, 2025 •

edited

Loading

CarinaWolli left a comment •

edited

Loading