write CWEs into database #705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add cwe ids from nvd weaknesses data Signed-off-by: Hasnat Bashir <[email protected]> * replaced MustCompile as it can cause program to crash Signed-off-by: Hasnat Bashir <[email protected]> * added cwe handle and updated nvd transformer to include cwe information Signed-off-by: Hasnat Bashir <[email protected]> * Update entry.go Signed-off-by: Hasnat Bashir <[email protected]> --------- Signed-off-by: Hasnat Bashir <[email protected]> Signed-off-by: Hasnat Bashir <[email protected]> Signed-off-by: Will Murphy <[email protected]>
Signed-off-by: Will Murphy <[email protected]>
Signed-off-by: Will Murphy <[email protected]>
Signed-off-by: Will Murphy <[email protected]>
Signed-off-by: Will Murphy <[email protected]>
willmurphyscode
commented
Oct 6, 2025
| } | ||
|
|
||
| func (w *writer) writeEntry(entry transformers.RelatedEntries) error { // nolint:gocognit | ||
| func (w *writer) writeEntry(entry transformers.RelatedEntries) error { |
There was a problem hiding this comment.
I split this up rather than have a nolint for cognitive load and line count.
willmurphyscode
commented
Oct 6, 2025
| github.com/adrg/xdg v0.5.3 | ||
| github.com/anchore/go-logger v0.0.0-20250318195838-07ae343dd722 | ||
| github.com/anchore/grype v0.100.0 | ||
| github.com/anchore/grype v0.100.1-0.20251003151438-d56b008a071c |
There was a problem hiding this comment.
The models are not yet released, so we had to bump grype.
willmurphyscode
commented
Oct 6, 2025
| var cwes []grypeDB.CWEHandle | ||
| for _, w := range vulnerability.Weaknesses { | ||
| for _, d := range w.Description { | ||
| if d.Value == "NVD-CWE-noinfo" || d.Value == "" { |
There was a problem hiding this comment.
There was formerly some more complex validation here, checking against a regex like CWE-\d+ or have the exact value NVD-CWE-Other. Since this is an uninterpreted string value in our data model, I don't see the need for further validation. Put another way: I don't want to change a regex if NVD comes up with another special CWE value besides NVD-CWE-noinfo and NVD-CWE-Other.
Here's a query:
❯ sqlite3 ./build/vulnerability.db "SELECT cwe, COUNT(*) AS occurrences FROM cwe_handles WHERE cwe NOT REGEXP '^CWE-\d+$' GROUP BY cwe ORDER BY occurrences DESC;"
NVD-CWE-Other|29673
Signed-off-by: Will Murphy <[email protected]>
wagoodman
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase / fixup of #660.