add cwe ids from nvd weaknesses data #660
Merged
+198
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hasnat Bashir <[email protected]>
Signed-off-by: Hasnat Bashir <[email protected]>
Signed-off-by: Hasnat Bashir <[email protected]>
Signed-off-by: Hasnat Bashir <[email protected]>
Signed-off-by: Hasnat Bashir <[email protected]>
kzantow
reviewed
Sep 17, 2025
pkg/provider/unmarshal/nvd/cve.go
Outdated
|
|
||
| func (o CveItem) GetCWEIDs() []string { | ||
| var cwes []string | ||
| var cwePattern = regexp.MustCompile(`^CWE-\d+$`) |
There was a problem hiding this comment.
This would only cause the program to crash if we are using user-provided input when generating the regex, since this is hardcoded it's safe to use MustCompile as a crash implies a programming error
willmurphyscode
approved these changes
Oct 4, 2025
willmurphyscode
pushed a commit
that referenced
this pull request
Oct 6, 2025
* add cwe ids from nvd weaknesses data Signed-off-by: Hasnat Bashir <[email protected]> * replaced MustCompile as it can cause program to crash Signed-off-by: Hasnat Bashir <[email protected]> * added cwe handle and updated nvd transformer to include cwe information Signed-off-by: Hasnat Bashir <[email protected]> * Update entry.go Signed-off-by: Hasnat Bashir <[email protected]> --------- Signed-off-by: Hasnat Bashir <[email protected]> Signed-off-by: Hasnat Bashir <[email protected]> Signed-off-by: Will Murphy <[email protected]>
willmurphyscode
added a commit
that referenced
this pull request
Oct 6, 2025
* add cwe ids from nvd weaknesses data (#660) * add cwe ids from nvd weaknesses data Signed-off-by: Hasnat Bashir <[email protected]> * replaced MustCompile as it can cause program to crash Signed-off-by: Hasnat Bashir <[email protected]> * added cwe handle and updated nvd transformer to include cwe information Signed-off-by: Hasnat Bashir <[email protected]> * Update entry.go Signed-off-by: Hasnat Bashir <[email protected]> --------- Signed-off-by: Hasnat Bashir <[email protected]> Signed-off-by: Hasnat Bashir <[email protected]> Signed-off-by: Will Murphy <[email protected]> * only skip no-info and blank CWEs Signed-off-by: Will Murphy <[email protected]> * finish rename and lints Signed-off-by: Will Murphy <[email protected]> * refactor writer function to break it down Signed-off-by: Will Murphy <[email protected]> * pull in grype@main Signed-off-by: Will Murphy <[email protected]> * restore CWE validation Signed-off-by: Will Murphy <[email protected]> --------- Signed-off-by: Hasnat Bashir <[email protected]> Signed-off-by: Hasnat Bashir <[email protected]> Signed-off-by: Will Murphy <[email protected]> Co-authored-by: Hasnat Bashir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Update grype reference once merged
Fixes #644