-
Notifications
You must be signed in to change notification settings - Fork 10
{RW-8595][risk=no] remove code referencing enable drug wildcard search #6996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{RW-8595][risk=no] remove code referencing enable drug wildcard search #6996
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert changes.
"enablePrivateDataprocWorker": true, | ||
"ccSupportWhenAdminLocking": false, | ||
"enableMultiReview": true, | ||
"enableDrugWildcardSearch": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Story only says to remove references to flag, but not the flag itself. Please revert.
"enablePrivateDataprocWorker": true, | ||
"ccSupportWhenAdminLocking": false, | ||
"enableMultiReview": false, | ||
"enableUpdatedDemographicSurvey": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Story only says to remove references to flag, but not the flag itself. Please revert.
"ccSupportWhenAdminLocking": true, | ||
"enableMultiReview": false, | ||
"enableUpdatedDemographicSurvey": true, | ||
"enableDrugWildcardSearch": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Story only says to remove references to flag, but not the flag itself. Please revert.
"ccSupportWhenAdminLocking": true, | ||
"enableMultiReview": false, | ||
"enableUpdatedDemographicSurvey": true, | ||
"enableDrugWildcardSearch": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Story only says to remove references to flag, but not the flag itself. Please revert.
"ccSupportWhenAdminLocking": false, | ||
"enableMultiReview": false, | ||
"enableUpdatedDemographicSurvey": true, | ||
"enableDrugWildcardSearch": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Story only says to remove references to flag, but not the flag itself. Please revert.
"ccSupportWhenAdminLocking": false, | ||
"enableMultiReview": false, | ||
"enableUpdatedDemographicSurvey": true, | ||
"enableDrugWildcardSearch": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Story only says to remove references to flag, but not the flag itself. Please revert.
"ccSupportWhenAdminLocking": false, | ||
"enableMultiReview": true, | ||
"enableUpdatedDemographicSurvey": true, | ||
"enableDrugWildcardSearch": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Story only says to remove references to flag, but not the flag itself. Please revert.
public boolean enableDrugWildcardSearch; | ||
// If true, enable Drug Wildcard Search for Cohort Builder - backend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Story only says to remove references to flag, but not the flag itself. Please revert.
@Mapping( | ||
target = "enableDrugWildcardSearch", | ||
source = "config.featureFlags.enableDrugWildcardSearch") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Story only says to remove references to flag, but not the flag itself. Please revert.
enableDrugWildcardSearch: | ||
type: boolean | ||
default: false | ||
description: Whether to enable wildcard search for Durgs in Cohort Builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Story only says to remove references to flag, but not the flag itself. Please revert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deployed and everything seems to be working, just a few comments on no longer needed test code.
serverConfigStore.set({ | ||
config: { | ||
...defaultServerConfig, | ||
enableDrugWildcardSearch: false, | ||
}, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the component no longer references serverConfigStore
we can remove it from the test also.
serverConfigStore.set({ | ||
config: { | ||
...defaultServerConfig, | ||
enableDrugWildcardSearch: false, | ||
}, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, can remove serverConfigStore
from the test.
serverConfigStore.set({ | ||
config: { | ||
...defaultServerConfig, | ||
enableDrugWildcardSearch: false, | ||
}, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can remove serverConfigStore
from the test.
serverConfigStore.set({ | ||
config: { | ||
...defaultServerConfig, | ||
enableDrugWildcardSearch: false, | ||
}, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can remove serverConfigStore
from the test.
serverConfigStore.set({ | ||
config: { | ||
...defaultServerConfig, | ||
enableDrugWildcardSearch: false, | ||
}, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can remove serverConfigStore
from the test.
Closing this PR as the changes are not in sync with my understanding of the requirements of the story. |
Description:
PR checklist