Skip to content

Conversation

chenchals
Copy link
Contributor

Description:

  • Remove feature flag from:
    • API classes and tests
    • Config files
    • UI components and tests
  • ran all tests for workbench/api

PR checklist

  • This PR meets the Acceptance Criteria in the JIRA story
  • The JIRA story has been moved to Dev Review
  • This PR includes appropriate unit tests
  • I have added explanatory comments where the logic is not obvious
  • I have run and tested this change locally, and my testing process is described here
  • If this includes a new feature flag, I have created and linked new JIRA tickets to (a) turn on the feature flag and (b) remove it later
  • If this includes an API change, I have run the E2E tests on this change against my local server with yarn test-local because this PR won't be covered by the CircleCI tests
  • If this includes a UI change, I have taken screen recordings or screenshots of the new behavior and notified the PO and UX designer in Slack
  • If this change impacts deployment safety (e.g. removing/altering APIs which are in use) I have documented these in the description
  • If this includes an API change, I have updated the appropriate Swagger definitions and updated the appropriate API consumers

Copy link
Contributor

@freemabd freemabd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert changes.

"enablePrivateDataprocWorker": true,
"ccSupportWhenAdminLocking": false,
"enableMultiReview": true,
"enableDrugWildcardSearch": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Story only says to remove references to flag, but not the flag itself. Please revert.

"enablePrivateDataprocWorker": true,
"ccSupportWhenAdminLocking": false,
"enableMultiReview": false,
"enableUpdatedDemographicSurvey": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Story only says to remove references to flag, but not the flag itself. Please revert.

"ccSupportWhenAdminLocking": true,
"enableMultiReview": false,
"enableUpdatedDemographicSurvey": true,
"enableDrugWildcardSearch": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Story only says to remove references to flag, but not the flag itself. Please revert.

"ccSupportWhenAdminLocking": true,
"enableMultiReview": false,
"enableUpdatedDemographicSurvey": true,
"enableDrugWildcardSearch": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Story only says to remove references to flag, but not the flag itself. Please revert.

"ccSupportWhenAdminLocking": false,
"enableMultiReview": false,
"enableUpdatedDemographicSurvey": true,
"enableDrugWildcardSearch": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Story only says to remove references to flag, but not the flag itself. Please revert.

"ccSupportWhenAdminLocking": false,
"enableMultiReview": false,
"enableUpdatedDemographicSurvey": true,
"enableDrugWildcardSearch": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Story only says to remove references to flag, but not the flag itself. Please revert.

"ccSupportWhenAdminLocking": false,
"enableMultiReview": true,
"enableUpdatedDemographicSurvey": true,
"enableDrugWildcardSearch": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Story only says to remove references to flag, but not the flag itself. Please revert.

Comment on lines -310 to -311
public boolean enableDrugWildcardSearch;
// If true, enable Drug Wildcard Search for Cohort Builder - backend
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Story only says to remove references to flag, but not the flag itself. Please revert.

Comment on lines -75 to -77
@Mapping(
target = "enableDrugWildcardSearch",
source = "config.featureFlags.enableDrugWildcardSearch")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Story only says to remove references to flag, but not the flag itself. Please revert.

Comment on lines -4442 to -4445
enableDrugWildcardSearch:
type: boolean
default: false
description: Whether to enable wildcard search for Durgs in Cohort Builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Story only says to remove references to flag, but not the flag itself. Please revert.

Copy link
Collaborator

@dolbeew dolbeew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployed and everything seems to be working, just a few comments on no longer needed test code.

Comment on lines 33 to 37
serverConfigStore.set({
config: {
...defaultServerConfig,
enableDrugWildcardSearch: false,
},
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the component no longer references serverConfigStore we can remove it from the test also.

Comment on lines 53 to 57
serverConfigStore.set({
config: {
...defaultServerConfig,
enableDrugWildcardSearch: false,
},
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, can remove serverConfigStore from the test.

Comment on lines 16 to 20
serverConfigStore.set({
config: {
...defaultServerConfig,
enableDrugWildcardSearch: false,
},
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove serverConfigStore from the test.

Comment on lines 32 to 36
serverConfigStore.set({
config: {
...defaultServerConfig,
enableDrugWildcardSearch: false,
},
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove serverConfigStore from the test.

Comment on lines 44 to 48
serverConfigStore.set({
config: {
...defaultServerConfig,
enableDrugWildcardSearch: false,
},
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove serverConfigStore from the test.

@chenchals
Copy link
Contributor Author

Closing this PR as the changes are not in sync with my understanding of the requirements of the story.

@chenchals chenchals closed this Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants