-
Notifications
You must be signed in to change notification settings - Fork 2.3k
url-helper.ts now leverages well-known environment variables.
#1941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+141
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jww3
commented
Oct 11, 2024
jww3
commented
Oct 11, 2024
jww3
commented
Oct 11, 2024
jww3
commented
Oct 16, 2024
jww3
commented
Oct 16, 2024
easyt
reviewed
Oct 16, 2024
easyt
reviewed
Oct 16, 2024
easyt
reviewed
Oct 16, 2024
Co-authored-by: Erez Testiler <[email protected]>
easyt
approved these changes
Oct 17, 2024
joshmgross
reviewed
Oct 17, 2024
joshmgross
previously approved these changes
Oct 17, 2024
Contributor
joshmgross
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments are not blocking, but please take a look 😄
joshmgross
approved these changes
Oct 17, 2024
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Oct 24, 2024
| datasource | package | from | to | | ----------- | ---------------- | ------ | ------ | | github-tags | actions/checkout | v4.1.7 | v4.2.2 | ## [vv4.2.2](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v422) - `url-helper.ts` now leverages well-known environment variables by [@jww3](https://github.com/jww3) in actions/checkout#1941 - Expand unit test coverage for `isGhes` by [@jww3](https://github.com/jww3) in actions/checkout#1946 ## [vv4.2.1](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v421) - Check out other refs/\* by commit if provided, fall back to ref by [@orhantoy](https://github.com/orhantoy) in actions/checkout#1924 ## [vv4.2.0](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v420) - Add Ref and Commit outputs by [@lucacome](https://github.com/lucacome) in actions/checkout#1180 - Dependency updates by [@dependabot-](https://github.com/dependabot-) actions/checkout#1777, actions/checkout#1872
This was referenced Nov 21, 2025
This was referenced Nov 24, 2025
mergify bot
added a commit
to ArcadeData/arcadedb
that referenced
this pull request
Nov 24, 2025
Bumps [actions/checkout](https://github.com/actions/checkout) from 5.0.0 to 6.0.0. Release notes *Sourced from [actions/checkout's releases](https://github.com/actions/checkout/releases).* > v6.0.0 > ------ > > What's Changed > -------------- > > * Update README to include Node.js 24 support details and requirements by [`@salmanmkc`](https://github.com/salmanmkc) in [actions/checkout#2248](https://redirect.github.com/actions/checkout/pull/2248) > * Persist creds to a separate file by [`@ericsciple`](https://github.com/ericsciple) in [actions/checkout#2286](https://redirect.github.com/actions/checkout/pull/2286) > * v6-beta by [`@ericsciple`](https://github.com/ericsciple) in [actions/checkout#2298](https://redirect.github.com/actions/checkout/pull/2298) > * update readme/changelog for v6 by [`@ericsciple`](https://github.com/ericsciple) in [actions/checkout#2311](https://redirect.github.com/actions/checkout/pull/2311) > > **Full Changelog**: <actions/checkout@v5.0.0...v6.0.0> > > v6-beta > ------- > > What's Changed > -------------- > > Updated persist-credentials to store the credentials under `$RUNNER_TEMP` instead of directly in the local git config. > > This requires a minimum Actions Runner version of [v2.329.0](https://github.com/actions/runner/releases/tag/v2.329.0) to access the persisted credentials for [Docker container action](https://docs.github.com/en/actions/tutorials/use-containerized-services/create-a-docker-container-action) scenarios. > > v5.0.1 > ------ > > What's Changed > -------------- > > * Port v6 cleanup to v5 by [`@ericsciple`](https://github.com/ericsciple) in [actions/checkout#2301](https://redirect.github.com/actions/checkout/pull/2301) > > **Full Changelog**: <actions/checkout@v5...v5.0.1> Changelog *Sourced from [actions/checkout's changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md).* > Changelog > ========= > > V6.0.0 > ------ > > * Persist creds to a separate file by [`@ericsciple`](https://github.com/ericsciple) in [actions/checkout#2286](https://redirect.github.com/actions/checkout/pull/2286) > * Update README to include Node.js 24 support details and requirements by [`@salmanmkc`](https://github.com/salmanmkc) in [actions/checkout#2248](https://redirect.github.com/actions/checkout/pull/2248) > > V5.0.1 > ------ > > * Port v6 cleanup to v5 by [`@ericsciple`](https://github.com/ericsciple) in [actions/checkout#2301](https://redirect.github.com/actions/checkout/pull/2301) > > V5.0.0 > ------ > > * Update actions checkout to use node 24 by [`@salmanmkc`](https://github.com/salmanmkc) in [actions/checkout#2226](https://redirect.github.com/actions/checkout/pull/2226) > > V4.3.1 > ------ > > * Port v6 cleanup to v4 by [`@ericsciple`](https://github.com/ericsciple) in [actions/checkout#2305](https://redirect.github.com/actions/checkout/pull/2305) > > V4.3.0 > ------ > > * docs: update README.md by [`@motss`](https://github.com/motss) in [actions/checkout#1971](https://redirect.github.com/actions/checkout/pull/1971) > * Add internal repos for checking out multiple repositories by [`@mouismail`](https://github.com/mouismail) in [actions/checkout#1977](https://redirect.github.com/actions/checkout/pull/1977) > * Documentation update - add recommended permissions to Readme by [`@benwells`](https://github.com/benwells) in [actions/checkout#2043](https://redirect.github.com/actions/checkout/pull/2043) > * Adjust positioning of user email note and permissions heading by [`@joshmgross`](https://github.com/joshmgross) in [actions/checkout#2044](https://redirect.github.com/actions/checkout/pull/2044) > * Update README.md by [`@nebuk89`](https://github.com/nebuk89) in [actions/checkout#2194](https://redirect.github.com/actions/checkout/pull/2194) > * Update CODEOWNERS for actions by [`@TingluoHuang`](https://github.com/TingluoHuang) in [actions/checkout#2224](https://redirect.github.com/actions/checkout/pull/2224) > * Update package dependencies by [`@salmanmkc`](https://github.com/salmanmkc) in [actions/checkout#2236](https://redirect.github.com/actions/checkout/pull/2236) > > v4.2.2 > ------ > > * `url-helper.ts` now leverages well-known environment variables by [`@jww3`](https://github.com/jww3) in [actions/checkout#1941](https://redirect.github.com/actions/checkout/pull/1941) > * Expand unit test coverage for `isGhes` by [`@jww3`](https://github.com/jww3) in [actions/checkout#1946](https://redirect.github.com/actions/checkout/pull/1946) > > v4.2.1 > ------ > > * Check out other refs/\* by commit if provided, fall back to ref by [`@orhantoy`](https://github.com/orhantoy) in [actions/checkout#1924](https://redirect.github.com/actions/checkout/pull/1924) > > v4.2.0 > ------ > > * Add Ref and Commit outputs by [`@lucacome`](https://github.com/lucacome) in [actions/checkout#1180](https://redirect.github.com/actions/checkout/pull/1180) > * Dependency updates by [`@dependabot`](https://github.com/dependabot)- [actions/checkout#1777](https://redirect.github.com/actions/checkout/pull/1777), [
url-helper.tshad unnecessary complexity which could cause it to incorrectly infer common URLs.This fix leverages well-known environment variables for the purposes of determining common URLs.