Skip to content

url-helper.ts now leverages well-known environment variables. #1941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jww3 merged 11 commits into from
Oct 18, 2024
Merged

url-helper.ts now leverages well-known environment variables. #1941

jww3 merged 11 commits into from
Oct 18, 2024
+141 −23

Conversation

@jww3
Copy link
Contributor

@jww3 jww3 commented Oct 11, 2024

url-helper.ts had unnecessary complexity which could cause it to incorrectly infer common URLs.

This fix leverages well-known environment variables for the purposes of determining common URLs.

jww3
jww3 commented Oct 11, 2024
View reviewed changes