Skip to content

add missing prefix to variables #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brennerm wants to merge 1 commit into from
Closed

add missing prefix to variables #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ Additional CLI options that must be appended to the minio server start command.

Minio access and secret keys.

skip_server: False
skip_client: False
minio_skip_server: False
Copy link
Collaborator

@SuperQ SuperQ Jun 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to positive wording to avoid the confusing double negative?

minio_install_server: true
minio_install_client: true

Copy link
Collaborator

@paulfantom paulfantom Jun 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this would be better

minio_skip_client: False

Switches to disable minio server and/or minio client installation.

Expand Down
4 changes: 2 additions & 2 deletions defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@ minio_access_key: ""
minio_secret_key: ""

# Switches to disable minio server and/or minio client installation
skip_server: False
skip_client: False
minio_skip_server: False
minio_skip_client: False
4 changes: 2 additions & 2 deletions tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
shell: /bin/bash

- include: server.yml
when: not skip_server
when: not minio_skip_server

- include: client.yml
when: not skip_client
when: not minio_skip_client