add missing prefix to variables #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atosatto
approved these changes
Jun 24, 2018
Owner
|
The failing CI has been fixed in #4. Thanks!!! |
SuperQ
requested changes
Jun 25, 2018
|
|
||
| skip_server: False | ||
| skip_client: False | ||
| minio_skip_server: False |
Collaborator
There was a problem hiding this comment.
Can we change this to positive wording to avoid the confusing double negative?
minio_install_server: true
minio_install_client: true
Collaborator
There was a problem hiding this comment.
I agree that this would be better
Collaborator
|
Superseded by #5. |
lucendio
referenced
this pull request
in wireapp/ansible-minio
Nov 20, 2020
allow specifying minio_{client,server}_{download_url,checksum}
akire0ne
pushed a commit
to akire0ne/ansible-minio
that referenced
this pull request
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents collision with variables from other roles.