Skip to content

service resource attributes #39335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
May 20, 2025
Merged

service resource attributes #39335

merged 30 commits into from
May 20, 2025

Conversation

zeitlinger
Copy link
Member

second part of #37114

@github-actions github-actions bot added the processor/k8sattributes k8s Attributes processor label Apr 11, 2025
@zeitlinger
Copy link
Member Author

@dmitryax @ChrsMark here is the second part - service attributes - please have a look 😄

@zeitlinger zeitlinger mentioned this pull request Apr 11, 2025
Closed
@github-actions github-actions bot mentioned this pull request Apr 15, 2025
Closed
ChrsMark
ChrsMark reviewed Apr 15, 2025
View reviewed changes
processor/k8sattributesprocessor/internal/kube/kube.go Outdated
Annotations []FieldExtractionRule
Labels []FieldExtractionRule

Service bool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just Service can be misleading. Can we use sth more explicit like ServiceAttributes instead?

@zeitlinger
Copy link
Member Author

@ChrsMark thanks for the review - I replied

@zeitlinger zeitlinger force-pushed the automatic-resource-attributes branch from 98c5df7 to 4a10785 Compare April 17, 2025 09:04
@github-actions github-actions bot mentioned this pull request Apr 22, 2025
Closed
ChrsMark
ChrsMark reviewed Apr 22, 2025
View reviewed changes
@zeitlinger zeitlinger force-pushed the automatic-resource-attributes branch from 4a10785 to f46e096 Compare April 22, 2025 12:19
@zeitlinger
Copy link
Member Author

@ChrsMark fixed (the changelog failure is a false positive)

ChrsMark
ChrsMark approved these changes Apr 23, 2025
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot mentioned this pull request Apr 29, 2025
Closed
@ChrsMark
Copy link
Member

ChrsMark commented May 5, 2025

@dmitryax could you also take a look so we can unblock this one?

@github-actions github-actions bot mentioned this pull request May 6, 2025
Closed
@github-actions github-actions bot mentioned this pull request May 13, 2025