Skip to content

service resource attributes #39335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
May 20, 2025
Merged

service resource attributes #39335

merged 30 commits into from
May 20, 2025

Conversation

zeitlinger
Copy link
Member

second part of #37114

@github-actions github-actions bot added the processor/k8sattributes k8s Attributes processor label Apr 11, 2025
@zeitlinger
Copy link
Member Author

@dmitryax @ChrsMark here is the second part - service attributes - please have a look 😄

@zeitlinger zeitlinger mentioned this pull request Apr 11, 2025
Closed
@github-actions github-actions bot mentioned this pull request Apr 15, 2025
Closed
ChrsMark
ChrsMark reviewed Apr 15, 2025
View reviewed changes
processor/k8sattributesprocessor/internal/kube/kube.go Outdated
Annotations []FieldExtractionRule
Labels []FieldExtractionRule

Service bool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just Service can be misleading. Can we use sth more explicit like ServiceAttributes instead?

@zeitlinger
Copy link
Member Author

@ChrsMark thanks for the review - I replied

@zeitlinger zeitlinger force-pushed the automatic-resource-attributes branch from 98c5df7 to 4a10785 Compare April 17, 2025 09:04
@github-actions github-actions bot mentioned this pull request Apr 22, 2025
Closed
ChrsMark
ChrsMark reviewed Apr 22, 2025
View reviewed changes
@zeitlinger zeitlinger force-pushed the automatic-resource-attributes branch from 4a10785 to f46e096 Compare April 22, 2025 12:19
@zeitlinger
Copy link
Member Author

@ChrsMark fixed (the changelog failure is a false positive)

ChrsMark
ChrsMark approved these changes Apr 23, 2025
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot mentioned this pull request Apr 29, 2025
Closed
@ChrsMark
Copy link
Member

ChrsMark commented May 5, 2025

@dmitryax could you also take a look so we can unblock this one?

@github-actions github-actions bot mentioned this pull request May 6, 2025
Closed
@github-actions github-actions bot mentioned this pull request May 13, 2025
Closed
@zeitlinger zeitlinger force-pushed the automatic-resource-attributes branch from 5c0bb01 to d80875d Compare May 13, 2025 07:23
@zeitlinger zeitlinger requested review from mx-psi and songy23 as code owners May 13, 2025 07:58
@zeitlinger zeitlinger force-pushed the automatic-resource-attributes branch from 90ecd28 to 0a574d1 Compare May 16, 2025 10:28
dmitryax
dmitryax reviewed May 16, 2025
View reviewed changes
@github-actions github-actions bot mentioned this pull request May 20, 2025
Closed
@dmitryax dmitryax merged commit 5b477f5 into open-telemetry:main May 20, 2025
175 checks passed
@github-actions github-actions bot added this to the next release milestone May 20, 2025
dragonlord93 pushed a commit to dragonlord93/opentelemetry-collector-contrib that referenced this pull request May 23, 2025
@zeitlinger @dragonlord93
service resource attributes (open-telemetry#39335)
d6752fe 
second part of
open-telemetry#37114
dd-jasminesun pushed a commit to DataDog/opentelemetry-collector-contrib that referenced this pull request Jun 23, 2025
@zeitlinger @dd-jasminesun
service resource attributes (open-telemetry#39335)
223adac 
second part of
open-telemetry#37114
@ChristianCiach ChristianCiach mentioned this pull request Jun 24, 2025
Closed
@zeitlinger zeitlinger deleted the automatic-resource-attributes branch September 25, 2025 16:17
@jmickey jmickey mentioned this pull request Oct 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

@dmitryax dmitryax dmitryax approved these changes

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 is a code owner

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner

@mx-psi mx-psi Awaiting requested review from mx-psi

@songy23 songy23 Awaiting requested review from songy23

@ankitpatel96 ankitpatel96 Awaiting requested review from ankitpatel96

@dineshg13 dineshg13 Awaiting requested review from dineshg13

@IbraheemA IbraheemA Awaiting requested review from IbraheemA

@jade-guiton-dd jade-guiton-dd Awaiting requested review from jade-guiton-dd

@liustanley liustanley Awaiting requested review from liustanley

@mackjmr mackjmr Awaiting requested review from mackjmr

+1 more reviewer

@cyrille-leclerc cyrille-leclerc cyrille-leclerc left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dmitryax dmitryax

Labels

connector/datadog exporter/datadog Datadog components processor/k8sattributes k8s Attributes processor waiting-for-code-owners

Projects

None yet

Milestone

v0.131.0

Development

Successfully merging this pull request may close these issues.

5 participants

@zeitlinger @ChrsMark @cyrille-leclerc @dmitryax @atoulme