Skip to content

[receiver/icmpcheckreceiver] New icmpcheckreceiver component skeleton. #43393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 10, 2025
Merged

[receiver/icmpcheckreceiver] New icmpcheckreceiver component skeleton. #43393

merged 4 commits into from
Oct 10, 2025
+668 −0

Conversation

jkoronaAtCisco
Copy link
Contributor

Description

Adding a new ICMP check receiver to perform echo requests to specified targets and collect metrics from responses.

This is first PR that introduces basic structure only, following CONTRIBUTING/Adding New Components guidelines:

  • README.md with In Development stability
  • config.go with validation for ping/echo targets
  • factory.go using helper factory APIs (returns a no-op metrics receiver for lifecycle tests)
  • doc.go with //go:generate mdatagen metadata.yaml
  • metadata.yaml and generated code under internal/metadata/
  • Basic unit tests (config, factory, lifecycle)

Link to tracking issue

#29009

Testing

  • Unit tests:
    • Config validation tests
    • Factory defaults and lifecycle
    • Generated lifecycle tests
  • Local repository checks run:
    • make checkdoc, make checkmetadata, make checkapi
    • make goporto, make crosslink, make gotidy
    • make genotelcontribcol, make genoteltestbedcol, make generate

Documentation

  • README.md with generated status badge
  • metadata.yaml with development stability
  • doc.go enabling mdatagen code generation

@atoulme - Component sponsor

@jkoronaAtCisco jkoronaAtCisco requested a review from a team as a code owner October 9, 2025 13:40
@jkoronaAtCisco jkoronaAtCisco requested a review from axw October 9, 2025 13:40
@jkoronaAtCisco jkoronaAtCisco mentioned this pull request Oct 9, 2025
Open
@jkoronaAtCisco jkoronaAtCisco changed the title [receiver/imcpcheckreceiver] New icmpcheckreceiver component skeleton. [receiver/icmpcheckreceiver] New icmpcheckreceiver component skeleton. Oct 9, 2025
@jkoronaAtCisco jkoronaAtCisco force-pushed the new-icmp-check-receiver branch from 5203d07 to e93b711 Compare October 9, 2025 13:54
@github-actions github-actions bot added the receiver/httpcheck HTTP Check receiver label Oct 9, 2025
@github-actions github-actions bot requested a review from VenuEmmadi October 9, 2025 13:54
@jkoronaAtCisco jkoronaAtCisco force-pushed the new-icmp-check-receiver branch from e93b711 to d15eb0d Compare October 9, 2025 13:59
@jkoronaAtCisco jkoronaAtCisco force-pushed the new-icmp-check-receiver branch from d15eb0d to b29b7ab Compare October 9, 2025 14:40
@atoulme
Copy link
Contributor

atoulme commented Oct 9, 2025

please run make genlabels and commit the change.

@songy23 songy23 merged commit fc5a520 into open-telemetry:main Oct 10, 2025
186 checks passed
@otelbot otelbot
Copy link
Contributor

otelbot bot commented Oct 10, 2025

Thank you for your contribution @jkoronaAtCisco! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help.

@github-actions github-actions bot added this to the next release milestone Oct 10, 2025
@jkoronaAtCisco jkoronaAtCisco deleted the new-icmp-check-receiver branch October 10, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme approved these changes

@axw axw Awaiting requested review from axw axw is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

@codeboten codeboten Awaiting requested review from codeboten

@VenuEmmadi VenuEmmadi Awaiting requested review from VenuEmmadi

Assignees
No one assigned
Labels
receiver/httpcheck HTTP Check receiver
Projects
None yet
Milestone
next release
Development

Successfully merging this pull request may close these issues.
3 participants
@jkoronaAtCisco @atoulme @songy23