Skip to content

[receiver/icmpcheckreceiver] New icmpcheckreceiver component skeleton. #43393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[receiver/icmpcheckreceiver] New icmpcheckreceiver component skeleton. #43393

wants to merge 2 commits into from

Conversation

jkoronaAtCisco
Copy link
Contributor

Description

Adding a new ICMP check receiver to perform echo requests to specified targets and collect metrics from responses.

This is first PR that introduces basic structure only, following CONTRIBUTING/Adding New Components guidelines:

  • README.md with In Development stability
  • config.go with validation for ping/echo targets
  • factory.go using helper factory APIs (returns a no-op metrics receiver for lifecycle tests)
  • doc.go with //go:generate mdatagen metadata.yaml
  • metadata.yaml and generated code under internal/metadata/
  • Basic unit tests (config, factory, lifecycle)

Link to tracking issue

#29009

Testing

  • Unit tests:
    • Config validation tests
    • Factory defaults and lifecycle
    • Generated lifecycle tests
  • Local repository checks run:
    • make checkdoc, make checkmetadata, make checkapi
    • make goporto, make crosslink, make gotidy
    • make genotelcontribcol, make genoteltestbedcol, make generate

Documentation

  • README.md with generated status badge
  • metadata.yaml with development stability
  • doc.go enabling mdatagen code generation

@atoulme - Component sponsor

@jkoronaAtCisco jkoronaAtCisco requested a review from a team as a code owner October 9, 2025 13:40
@jkoronaAtCisco jkoronaAtCisco requested a review from axw October 9, 2025 13:40
@jkoronaAtCisco jkoronaAtCisco mentioned this pull request Oct 9, 2025
Open
@jkoronaAtCisco jkoronaAtCisco changed the title [receiver/imcpcheckreceiver] New icmpcheckreceiver component skeleton. [receiver/icmpcheckreceiver] New icmpcheckreceiver component skeleton. Oct 9, 2025
@jkoronaAtCisco jkoronaAtCisco force-pushed the new-icmp-check-receiver branch from 5203d07 to e93b711 Compare October 9, 2025 13:54
@github-actions github-actions bot added the receiver/httpcheck HTTP Check receiver label Oct 9, 2025
@github-actions github-actions bot requested a review from VenuEmmadi October 9, 2025 13:54
@jkoronaAtCisco jkoronaAtCisco force-pushed the new-icmp-check-receiver branch from e93b711 to d15eb0d Compare October 9, 2025 13:59
@jkoronaAtCisco jkoronaAtCisco force-pushed the new-icmp-check-receiver branch from d15eb0d to b29b7ab Compare October 9, 2025 14:40
@atoulme
Copy link
Contributor

atoulme commented Oct 9, 2025

please run make genlabels and commit the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme approved these changes

@axw axw Awaiting requested review from axw axw is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

@codeboten codeboten Awaiting requested review from codeboten

@VenuEmmadi VenuEmmadi Awaiting requested review from VenuEmmadi

Assignees
No one assigned
Labels
receiver/httpcheck HTTP Check receiver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkoronaAtCisco @atoulme