Skip to content

Conversation

@HippocampusGirl
Copy link
Contributor

With the most recent pandas version, I am getting the following warning:

/usr/local/miniconda/lib/python3.7/site-packages/niworkflows/interfaces/utils.py:896: FutureWarning: In a future version of pandas all arguments of read_csv except for the argument 'filepath_or_buffer' will be keyword-only

I have attached the required change to avoid it.

Copy link
Member

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2021

Codecov Report

Merging #645 (3a3d837) into maint/1.3.x (691436a) will decrease coverage by 47.95%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           maint/1.3.x    #645       +/-   ##
===============================================
- Coverage        47.95%   0.00%   -47.96%     
===============================================
  Files               43      43               
  Lines             5303    5301        -2     
  Branches           775     775               
===============================================
- Hits              2543       0     -2543     
- Misses            2673    5301     +2628     
+ Partials            87       0       -87     
Flag Coverage Δ
documentation 0.00% <0.00%> (ø)
reportlettests ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
niworkflows/interfaces/utils.py 0.00% <0.00%> (-40.15%) ⬇️
niworkflows/__about__.py 0.00% <0.00%> (-100.00%) ⬇️
niworkflows/viz/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
niworkflows/anat/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
niworkflows/engine/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
niworkflows/interfaces/space.py 0.00% <0.00%> (-100.00%) ⬇️
niworkflows/reports/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
niworkflows/utils/connections.py 0.00% <0.00%> (-100.00%) ⬇️
niworkflows/interfaces/nibabel.py 0.00% <0.00%> (-100.00%) ⬇️
niworkflows/interfaces/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 691436a...3a3d837. Read the comment docs.

@effigies
Copy link
Member

I think the keyword is delimiter? I can't open the failing test on my phone, though.

@HippocampusGirl
Copy link
Contributor Author

As far as I know, pandas supports both the sep and delimiter keyword arguments.

I just had a look, the error is something else.

E   ImportError: A sklearn version of at least 0.21 is required to use nilearn. 0.19.2 was found. Please upgrade sklearn

@effigies
Copy link
Member

Got it. So we need to update our Dockerfile around here: https://github.com/nipreps/niworkflows/blob/master/Dockerfile#L126

@HippocampusGirl
Copy link
Contributor Author

Should I submit a separate PR for the Dockerfile update?

@oesteban
Copy link
Member

oesteban commented Aug 5, 2021

I think we can use this PR :)

@oesteban oesteban merged commit 43d4646 into nipreps:maint/1.3.x Aug 5, 2021
@HippocampusGirl HippocampusGirl deleted the fix-pandas-warning branch June 28, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants