Skip to content

Fix LSP warnings on pipeline template #3905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mashehu merged 7 commits into from
Nov 18, 2025
Merged

Fix LSP warnings on pipeline template #3905

mashehu merged 7 commits into from
Nov 18, 2025

Conversation

@dialvarezs
Copy link
Member

@dialvarezs dialvarezs commented Nov 17, 2025 •
edited
Loading

This PR makes a few changes on the pipeline template to address LSP warnings:

  • It changes Channel by channel to address the new deprecation
  • It fixes an anonymous parameter in a closure

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@dialvarezs dialvarezs changed the base branch from main to dev November 17, 2025 16:06
@nf-core nf-core deleted a comment from github-actions bot Nov 17, 2025
mashehu
mashehu requested changes Nov 17, 2025
View reviewed changes
Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! One change needs to be done in the upstream subworkflow

@codecov
Copy link

codecov bot commented Nov 17, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.45%. Comparing base (ef733fa) to head (c4161da).
⚠️ Report is 2 commits behind head on dev.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mashehu mashehu added this to the 3.5.0 milestone Nov 18, 2025
mirpedrol
mirpedrol approved these changes Nov 18, 2025
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dialvarezs

@mashehu mashehu merged commit d823888 into nf-core:dev Nov 18, 2025
114 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mashehu mashehu mashehu approved these changes

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@dialvarezs @mashehu @mirpedrol