Skip to content

Commit d823888

Browse files
dialvarezsmirpedrolmashehu
authored
Fix LSP warnings on pipeline template (#3905)
Co-authored-by: Júlia Mir Pedrol <[email protected]> Co-authored-by: Matthias Hörtenhuber <[email protected]>
1 parent 530a7a1 commit d823888

File tree

5 files changed

+15
-14
lines changed

5 files changed

+15
-14
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434

3535
- Change GitHub Codespaces badge style ([#3869](https://github.com/nf-core/tools/pull/3869) and [#3873](https://github.com/nf-core/tools/pull/3873))
3636
- Update multiqc to 1.32 ([#3878](https://github.com/nf-core/tools/pull/3878))
37+
- Fix LSP warnings in pipeline template ([#3905](https://github.com/nf-core/tools/pull/3905))
3738

3839
### Linting
3940

nf_core/pipeline-template/modules.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
},
2929
"utils_nfcore_pipeline": {
3030
"branch": "master",
31-
"git_sha": "05954dab2ff481bcb999f24455da29a5828af08d",
31+
"git_sha": "271e7fc14eb1320364416d996fb077421f3faed2",
3232
"installed_by": ["subworkflows"]
3333
}{% if nf_schema %},
3434
"utils_nfschema_plugin": {

nf_core/pipeline-template/subworkflows/local/utils_nfcore_pipeline_pipeline/main.nf

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ workflow PIPELINE_INITIALISATION {
4343

4444
main:
4545

46-
ch_versions = Channel.empty()
46+
ch_versions = channel.empty()
4747

4848
//
4949
// Print version and exit if required and dump pipeline parameters to JSON file
@@ -72,7 +72,7 @@ workflow PIPELINE_INITIALISATION {
7272
\033[0;35m {{ name }} ${workflow.manifest.version}\033[0m
7373
-\033[2m----------------------------------------------------\033[0m-
7474
"""
75-
after_text = """${workflow.manifest.doi ? "\n* The pipeline\n" : ""}${workflow.manifest.doi.tokenize(",").collect { " https://doi.org/${it.trim().replace('https://doi.org/','')}"}.join("\n")}${workflow.manifest.doi ? "\n" : ""}
75+
after_text = """${workflow.manifest.doi ? "\n* The pipeline\n" : ""}${workflow.manifest.doi.tokenize(",").collect { doi -> " https://doi.org/${doi.trim().replace('https://doi.org/','')}"}.join("\n")}${workflow.manifest.doi ? "\n" : ""}
7676
* The nf-core framework
7777
https://doi.org/10.1038/s41587-020-0439-x
7878
@@ -113,7 +113,7 @@ workflow PIPELINE_INITIALISATION {
113113
// Create channel from input file provided through params.input
114114
//
115115

116-
Channel{% if nf_schema %}
116+
channel{% if nf_schema %}
117117
.fromList(samplesheetToList(params.input, "${projectDir}/assets/schema_input.json")){% else %}
118118
.fromPath(params.input)
119119
.splitCsv(header: true, strip: true)

nf_core/pipeline-template/subworkflows/nf-core/utils_nfcore_pipeline/main.nf

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

nf_core/pipeline-template/workflows/pipeline.nf

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@ workflow {{ short_name|upper }} {
3232
{%- if modules %}
3333
main:
3434

35-
ch_versions = Channel.empty()
35+
ch_versions = channel.empty()
3636
{%- if multiqc %}
37-
ch_multiqc_files = Channel.empty(){% endif %}
37+
ch_multiqc_files = channel.empty(){% endif %}
3838

3939
{%- if fastqc %}
4040
//
@@ -80,20 +80,20 @@ workflow {{ short_name|upper }} {
8080
//
8181
// MODULE: MultiQC
8282
//
83-
ch_multiqc_config = Channel.fromPath(
83+
ch_multiqc_config = channel.fromPath(
8484
"$projectDir/assets/multiqc_config.yml", checkIfExists: true)
8585
ch_multiqc_custom_config = params.multiqc_config ?
86-
Channel.fromPath(params.multiqc_config, checkIfExists: true) :
87-
Channel.empty()
86+
channel.fromPath(params.multiqc_config, checkIfExists: true) :
87+
channel.empty()
8888
ch_multiqc_logo = params.multiqc_logo ?
89-
Channel.fromPath(params.multiqc_logo, checkIfExists: true) :
90-
Channel.empty()
89+
channel.fromPath(params.multiqc_logo, checkIfExists: true) :
90+
channel.empty()
9191

9292
{%- if nf_schema %}
9393

9494
summary_params = paramsSummaryMap(
9595
workflow, parameters_schema: "nextflow_schema.json")
96-
ch_workflow_summary = Channel.value(paramsSummaryMultiqc(summary_params))
96+
ch_workflow_summary = channel.value(paramsSummaryMultiqc(summary_params))
9797
ch_multiqc_files = ch_multiqc_files.mix(
9898
ch_workflow_summary.collectFile(name: 'workflow_summary_mqc.yaml'))
9999
{%- endif %}
@@ -102,7 +102,7 @@ workflow {{ short_name|upper }} {
102102
ch_multiqc_custom_methods_description = params.multiqc_methods_description ?
103103
file(params.multiqc_methods_description, checkIfExists: true) :
104104
file("$projectDir/assets/methods_description_template.yml", checkIfExists: true)
105-
ch_methods_description = Channel.value(
105+
ch_methods_description = channel.value(
106106
methodsDescriptionText(ch_multiqc_custom_methods_description))
107107
{%- endif %}
108108

0 commit comments

Comments
 (0)