Addresses comments in PR #10 and relaxes region requirement #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add support for aws profile - support profile definition from ENV - support region definition from ENV - detect regrion from CLI config files
* Provides mapping for credentials from old configuration schema to new. * Adds newlines to end of test files * Auto-detects regions via S3MultiRegionClient instead of assuming us-east-1 if not explicitly configured.
Owner
|
Tagged this as https://github.com/naderman/composer-aws/releases/tag/1.0.0 |
QiSHUXING
approved these changes
Jun 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You should be able to compare with PR #10 via fdewinne/composer-aws@master...nativex:master
Context refresher: PR #10 updates to the latest version of the AWS PHP SDK and adds support for profiles and regions. There are three previously unaddressed comments in that pull request that should hopefully be resolved here:
Additionally, I've removed the hard requirement for users to supply a region if the target bucket exists outside of the us-east-1 . Execution now proceeds (instead of failing due to a missing bucket that actually does exists in another region) with slightly poorer performance and the user is warned.