update to AWS SDK PHP 3.x & add profile/region support #10
Conversation
- add support for aws profile - support profile definition from ENV - support region definition from ENV - detect regrion from CLI config files
.gitignore
Outdated
| @@ -1 +1,3 @@ | |||
| .idea | |||
| /vendor | |||
| composer.lock | |||
There was a problem hiding this comment.
Please do not ignore the lock file, properly update it and commit it.
|
I just restored the composer.lock file... even if it's not necessary in this case. |
|
@fdewinne Yes but while the file is not needed for installing the library or plugin it has advantages to keep a lock file for libraries regardless: The use of composer install in CI is faster and deterministic (without the lock composer runs an So I keep recommending to people to always keep a lock file, even if it's not needed for users of the library technically. |
|
By the way thanks for the PR! Just got distracted yesterday when I started the review so only left you with that one silly comment on the first file ;-) |
| $s3config['key'] = $key; | ||
| $s3config['secret'] = $secret; | ||
| if (($composerAws = $config->get('amazon-aws'))) { | ||
| $s3config = array_merge($s3config, $composerAws); |
There was a problem hiding this comment.
Do you think you can just stick in the "credentials" key here if needed, so that the config remains backward compatible?
|
Looks great apart from what I mentioned :-) |
* Provides mapping for credentials from old configuration schema to new. * Adds newlines to end of test files * Auto-detects regions via S3MultiRegionClient instead of assuming us-east-1 if not explicitly configured.
Addresses comments in PR #10 and relaxes region requirement
|
Tagged this as https://github.com/naderman/composer-aws/releases/tag/1.0.0 |
This update adds the following features:
This update also provides unit tests: