Skip to content

Fix context.views.open in slack home tab #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 22, 2020
Merged

Fix context.views.open in slack home tab #809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c3e16b
fix: context.views.open in Slack home tab
etrex Jun 17, 2020
3708109
fix: the sessionKey of interactive event on slack channel modal
etrex Jun 18, 2020
efe533e
test: fix test
etrex Jun 18, 2020
3f50d9d
test: fix data
etrex Jun 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/bottender/src/slack/SlackConnector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,10 @@ export default class SlackConnector

// For slack modal
if (rawEvent.view && rawEvent.view.privateMetadata) {
return JSON.parse(rawEvent.view.privateMetadata).channelId;
const channelId = JSON.parse(rawEvent.view.privateMetadata).channelId;
if (channelId) {
return channelId;
}
}

// For reaction_added format
Expand Down
2 changes: 1 addition & 1 deletion packages/bottender/src/slack/SlackContext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ export default class SlackContext extends Context<
...options.view,
privateMetadata: JSON.stringify({
original: options.view.privateMetadata,
channelId: (this._event.rawEvent as UIEvent).channel.id,
channelId: (this._event.rawEvent as UIEvent).channel?.id,
}),
},
});
Expand Down
2 changes: 1 addition & 1 deletion packages/bottender/src/slack/SlackTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export type UIEvent = {
id: string;
domain: string;
};
channel: {
channel?: {
id: string;
name: string;
};
Expand Down
Loading