Skip to content

Fix context.views.open in slack home tab #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 22, 2020
Merged

Fix context.views.open in slack home tab #809

merged 4 commits into from
Jun 22, 2020

Conversation

@etrex
Copy link
Contributor

@etrex etrex commented Jun 17, 2020 •
edited
Loading

previous implement

  • Set channelId to view.privateMetadata to store the session key in the view.
  • If a webhook event from button clicked on a modal, get sessionKey from view.privateMetadata.

current implement

  • Get sessionKey from channelId or userId.
  • If a webhook event from button clicked on a channel modal, get sessionKey from view.privateMetadata.
  • If a webhook event from button clicked on a home modal, get sessionKey from user id.

@chentsulin chentsulin changed the base branch from master to release/1.5 June 17, 2020 10:41
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2020 •
edited
Loading

Codecov Report

Merging #809 into release/1.5 will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/1.5     #809   +/-   ##
============================================
  Coverage        83.93%   83.93%           
============================================
  Files              120      120           
  Lines             6167     6169    +2     
  Branches          1523     1525    +2     
============================================
+ Hits              5176     5178    +2     
  Misses             987      987           
  Partials             4        4
Impacted Files Coverage Δ
packages/bottender/src/slack/SlackTypes.ts 100.00% <ø> (ø)
packages/bottender/src/slack/SlackConnector.ts 91.56% <100.00%> (+0.10%) ⬆️
packages/bottender/src/slack/SlackContext.ts 92.30% <100.00%> (+0.09%) ⬆️
packages/bottender-facebook/src/FacebookContext.ts 74.39% <0.00%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 611534b...3f50d9d. Read the comment docs.

@chentsulin chentsulin requested a review from tw0517tw June 18, 2020 03:51
@etrex etrex requested a review from tw0517tw June 18, 2020 12:09
@chentsulin chentsulin merged commit 671b61c into release/1.5 Jun 22, 2020
@chentsulin chentsulin deleted the fix-context.views.open-in-slack-home-tab branch June 22, 2020 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tw0517tw tw0517tw tw0517tw approved these changes

@chentsulin chentsulin chentsulin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@etrex @codecov-commenter @tw0517tw @chentsulin