fix: Link with boost libraries explicitly #5546

mathbunnyru · 2025-07-09T18:44:25Z

High Level Overview of Change

boost::boost in self.requires makes clio to link with all boost libraries.
What's worse, there are several boost stacktrace backends, and we link with both and violate ODR.
This fixes the problem.

Context of Change

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Refactor (non-breaking change that only restructures code)
Performance (increase or change in throughput and/or latency)
Tests (you added tests for code that already exists, or your new feature included in this PR)
Documentation update
Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
Release

API Impact

Public API: New feature (new methods and/or new fields)
Public API: Breaking change (in general, breaking changes should only impact the next api_version)
libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
Peer protocol change (must be backward compatible or bump the peer protocol version)

mathbunnyru · 2025-07-09T18:47:31Z

cmake/deps/Boost.cmake

  COMPONENTS
    chrono
    container
-    context


This is not used below, and I greped the code - it's not used anywhere, so let's keep these lists in sync

codecov · 2025-07-09T19:10:51Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.0%. Comparing base (f47e2f4) to head (f21ffc8).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #5546     +/-   ##
=========================================
- Coverage     79.1%   79.0%   -0.0%     
=========================================
  Files          816     816             
  Lines        71623   71621      -2     
  Branches      8236    8258     +22     
=========================================
- Hits         56645   56616     -29     
- Misses       14978   15005     +27

see 6 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Bronek

Good call !

…refactoring-1 * upstream/develop: (56 commits) Remove `include(default)` from libxrpl profile (#5587) refactor: Change boost::shared_mutex to std::shared_mutex (#5576) Fix macos runner (#5585) Remove the type filter from "ledger" RPC command (#4934) refactor: Update date, libarchive, nudb, openssl, sqlite3, xxhash packages (#5567) test: Run unit tests regardless of 'Supported' amendment status (#5537) Retire Flow Cross amendment (#5562) chore: Update CI to use Conan 2 (#5556) fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513) chore: Add gcc-12 workaround (#5554) Add MPT related txns into issuer's account history (#5530) chore: Remove unused headers (#5526) fix: add allowTrustLineLocking flag for account_info (#5525) Downgrade required CMake version for Antithesis SDK (#5548) fix: Link with boost libraries explicitly (#5546) chore: Fix compilation error with clang-20 and cleanup (#5543) test: Remove circular jtx.h dependencies (#5544) Decouple CredentialHelpers from xrpld/app/tx (#5487) fix: crash when trace-logging in tests (#5529) test: switch some unit tests to doctest (#5383) ...

…actoring-2 * ximinez/lending-refactoring-1: (57 commits) Fix formatting Remove `include(default)` from libxrpl profile (#5587) refactor: Change boost::shared_mutex to std::shared_mutex (#5576) Fix macos runner (#5585) Remove the type filter from "ledger" RPC command (#4934) refactor: Update date, libarchive, nudb, openssl, sqlite3, xxhash packages (#5567) test: Run unit tests regardless of 'Supported' amendment status (#5537) Retire Flow Cross amendment (#5562) chore: Update CI to use Conan 2 (#5556) fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513) chore: Add gcc-12 workaround (#5554) Add MPT related txns into issuer's account history (#5530) chore: Remove unused headers (#5526) fix: add allowTrustLineLocking flag for account_info (#5525) Downgrade required CMake version for Antithesis SDK (#5548) fix: Link with boost libraries explicitly (#5546) chore: Fix compilation error with clang-20 and cleanup (#5543) test: Remove circular jtx.h dependencies (#5544) Decouple CredentialHelpers from xrpld/app/tx (#5487) fix: crash when trace-logging in tests (#5529) ...

…actoring-3 * ximinez/lending-refactoring-2: (57 commits) Fix formatting Remove `include(default)` from libxrpl profile (#5587) refactor: Change boost::shared_mutex to std::shared_mutex (#5576) Fix macos runner (#5585) Remove the type filter from "ledger" RPC command (#4934) refactor: Update date, libarchive, nudb, openssl, sqlite3, xxhash packages (#5567) test: Run unit tests regardless of 'Supported' amendment status (#5537) Retire Flow Cross amendment (#5562) chore: Update CI to use Conan 2 (#5556) fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513) chore: Add gcc-12 workaround (#5554) Add MPT related txns into issuer's account history (#5530) chore: Remove unused headers (#5526) fix: add allowTrustLineLocking flag for account_info (#5525) Downgrade required CMake version for Antithesis SDK (#5548) fix: Link with boost libraries explicitly (#5546) chore: Fix compilation error with clang-20 and cleanup (#5543) test: Remove circular jtx.h dependencies (#5544) Decouple CredentialHelpers from xrpld/app/tx (#5487) fix: crash when trace-logging in tests (#5529) ...

…actoring-4 * ximinez/lending-refactoring-3: (61 commits) fixup! Rename Transactor preflight functions Rename Transactor preflight functions fixup! Make preflight1 and preflight2 private static Transactor functions Make preflight1 and preflight2 private static Transactor functions Fix formatting Remove `include(default)` from libxrpl profile (#5587) refactor: Change boost::shared_mutex to std::shared_mutex (#5576) Fix macos runner (#5585) Remove the type filter from "ledger" RPC command (#4934) refactor: Update date, libarchive, nudb, openssl, sqlite3, xxhash packages (#5567) test: Run unit tests regardless of 'Supported' amendment status (#5537) Retire Flow Cross amendment (#5562) chore: Update CI to use Conan 2 (#5556) fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513) chore: Add gcc-12 workaround (#5554) Add MPT related txns into issuer's account history (#5530) chore: Remove unused headers (#5526) fix: add allowTrustLineLocking flag for account_info (#5525) Downgrade required CMake version for Antithesis SDK (#5548) fix: Link with boost libraries explicitly (#5546) ...

…actoring-4 * ximinez/lending-refactoring-3: (61 commits) fixup! Rename Transactor preflight functions Rename Transactor preflight functions fixup! Make preflight1 and preflight2 private static Transactor functions Make preflight1 and preflight2 private static Transactor functions Fix formatting Remove `include(default)` from libxrpl profile (#5587) refactor: Change boost::shared_mutex to std::shared_mutex (#5576) Fix macos runner (#5585) Remove the type filter from "ledger" RPC command (#4934) refactor: Update date, libarchive, nudb, openssl, sqlite3, xxhash packages (#5567) test: Run unit tests regardless of 'Supported' amendment status (#5537) Retire Flow Cross amendment (#5562) chore: Update CI to use Conan 2 (#5556) fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513) chore: Add gcc-12 workaround (#5554) Add MPT related txns into issuer's account history (#5530) chore: Remove unused headers (#5526) fix: add allowTrustLineLocking flag for account_info (#5525) Downgrade required CMake version for Antithesis SDK (#5548) fix: Link with boost libraries explicitly (#5546) ... Co-authored-by: Bronek Kozicki <[email protected]>

Co-authored-by: Jingchen <[email protected]> Co-authored-by: Bronek Kozicki <[email protected]> Co-authored-by: Ayaz Salikhov <[email protected]> Co-authored-by: Denis Angell <[email protected]> Co-authored-by: Vlad <[email protected]> Co-authored-by: Shawn Xie <[email protected]> Co-authored-by: yinyiqian1 <[email protected]> Co-authored-by: Michael Legleux <[email protected]> Co-authored-by: Bart <[email protected]> Co-authored-by: Chenna Keshava B S <[email protected]> Co-authored-by: Vito Tumas <[email protected]> Co-authored-by: Luc des Trois Maisons <[email protected]> Co-authored-by: Valentin Balaschenko <[email protected]> fix: crash when trace-logging in tests (#5529) Fix compilation error with clang-20 and cleanup (#5543) fix: Link with boost libraries explicitly (#5546) fix: add allowTrustLineLocking flag for account_info (#5525) fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513) Fix macos runner (#5585) Fix clang-format CI job (#5598) resolved actions/runner#2058.

#2329) … of rippled See: XRPLF/rippled#5546

fix: Link with boost libraries explicitly

f21ffc8

mathbunnyru force-pushed the explicit_boost branch from c648af5 to f21ffc8 Compare July 9, 2025 18:46

mathbunnyru commented Jul 9, 2025

View reviewed changes

mathbunnyru mentioned this pull request Jul 9, 2025

fix: Link with boost libraries explicitly XRPLF/clio#2313

Merged

godexsoft requested a review from Bronek July 9, 2025 20:30

godexsoft approved these changes Jul 9, 2025

View reviewed changes

Bronek approved these changes Jul 10, 2025

View reviewed changes

bthomee merged commit 358b7f5 into XRPLF:develop Jul 10, 2025
24 checks passed

mathbunnyru mentioned this pull request Jul 14, 2025

fix: Do not link to several boost::stacktrace implementations because… XRPLF/clio#2329

Merged

mathbunnyru added a commit to XRPLF/clio that referenced this pull request Jul 29, 2025

fix: Do not link to several boost::stacktrace implementations because… (

d7888d5

#2329) … of rippled See: XRPLF/rippled#5546

This was referenced Aug 27, 2025

Release 2.6.0 #5741

Merged

Release 2.6.0 #5742

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Link with boost libraries explicitly #5546

fix: Link with boost libraries explicitly #5546

Uh oh!

mathbunnyru commented Jul 9, 2025

Uh oh!

mathbunnyru Jul 9, 2025

Uh oh!

codecov bot commented Jul 9, 2025 •

edited

Loading

Uh oh!

Bronek left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix: Link with boost libraries explicitly #5546

fix: Link with boost libraries explicitly #5546

Uh oh!

Conversation

mathbunnyru commented Jul 9, 2025

High Level Overview of Change

Context of Change

Type of Change

API Impact

Uh oh!

mathbunnyru Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Bronek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jul 9, 2025 •

edited

Loading