Add MPT related txns into issuer's account history #5530

shawnxie999 · 2025-07-02T17:51:32Z

High Level Overview of Change

Currently there is no easy way to track MPT related transactions for the issuer. This change allows MPT transactions to show up on issuer's AccountTx RPC (to align with how IOUs work)

Context of Change

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Refactor (non-breaking change that only restructures code)
Performance (increase or change in throughput and/or latency)
Tests (you added tests for code that already exists, or your new feature included in this PR)
Documentation update
Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
Release

API Impact

Public API: New feature (new methods and/or new fields)
Public API: Breaking change (in general, breaking changes should only impact the next api_version)
libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
Peer protocol change (must be backward compatible or bump the peer protocol version)

gregtatcam

LGTM 👍

mDuo13 · 2025-07-08T01:54:27Z

Is this not a transaction processing change that should be on an amendment?

shawnxie999 · 2025-07-08T15:24:22Z

Is this not a transaction processing change that should be on an amendment?

@mDuo13 AFAIK, this only affects the account transaction DB, it doesn't affect transaction processing and metadata. cc @ximinez could you help confirm this is the case?

yinyiqian1

LGTM

codecov · 2025-07-08T18:54:26Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.1%. Comparing base (6534757) to head (8bb46c5).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #5530     +/-   ##
=========================================
- Coverage     79.1%   79.1%   -0.0%     
=========================================
  Files          816     816             
  Lines        71625   71632      +7     
  Branches      8238    8257     +19     
=========================================
- Hits         56646   56630     -16     
- Misses       14979   15002     +23

Files with missing lines	Coverage Δ
src/libxrpl/protocol/TxMeta.cpp	`96.7% <100.0%> (+0.2%)`	⬆️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

src/libxrpl/protocol/TxMeta.cpp

ximinez · 2025-07-10T17:32:15Z

Is this not a transaction processing change that should be on an amendment?

AFAIK, this only affects the account transaction DB, it doesn't affect transaction processing and metadata. cc @ximinez could you help confirm this is the case?

Metadata is written to the ledger. This absolutely needs an amendment.

ximinez

Modifies ledger metadata. Needs an amendment.

shawnxie999 · 2025-07-10T17:51:08Z

@ximinez this doesn't actually modify the metadata(mNodes), it only updates mAffected to include extra accounts. mAffected is only used by AcceptedLedgerTx JSON, which isn't part of the actual transaction metadata

I misunderstood what this change was doing the first time I looked at it. I saw TxMeta and some mentions of metadata, and figured that meant it was changing transaction metadata. It's only reading transaction metadata, which does not require an amendment.

src/test/rpc/AccountTx_test.cpp

* XRPLF/develop: fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513) chore: Add gcc-12 workaround (#5554) Add MPT related txns into issuer's account history (#5530) chore: Remove unused headers (#5526)

…refactoring-1 * upstream/develop: (56 commits) Remove `include(default)` from libxrpl profile (#5587) refactor: Change boost::shared_mutex to std::shared_mutex (#5576) Fix macos runner (#5585) Remove the type filter from "ledger" RPC command (#4934) refactor: Update date, libarchive, nudb, openssl, sqlite3, xxhash packages (#5567) test: Run unit tests regardless of 'Supported' amendment status (#5537) Retire Flow Cross amendment (#5562) chore: Update CI to use Conan 2 (#5556) fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513) chore: Add gcc-12 workaround (#5554) Add MPT related txns into issuer's account history (#5530) chore: Remove unused headers (#5526) fix: add allowTrustLineLocking flag for account_info (#5525) Downgrade required CMake version for Antithesis SDK (#5548) fix: Link with boost libraries explicitly (#5546) chore: Fix compilation error with clang-20 and cleanup (#5543) test: Remove circular jtx.h dependencies (#5544) Decouple CredentialHelpers from xrpld/app/tx (#5487) fix: crash when trace-logging in tests (#5529) test: switch some unit tests to doctest (#5383) ...

…actoring-2 * ximinez/lending-refactoring-1: (57 commits) Fix formatting Remove `include(default)` from libxrpl profile (#5587) refactor: Change boost::shared_mutex to std::shared_mutex (#5576) Fix macos runner (#5585) Remove the type filter from "ledger" RPC command (#4934) refactor: Update date, libarchive, nudb, openssl, sqlite3, xxhash packages (#5567) test: Run unit tests regardless of 'Supported' amendment status (#5537) Retire Flow Cross amendment (#5562) chore: Update CI to use Conan 2 (#5556) fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513) chore: Add gcc-12 workaround (#5554) Add MPT related txns into issuer's account history (#5530) chore: Remove unused headers (#5526) fix: add allowTrustLineLocking flag for account_info (#5525) Downgrade required CMake version for Antithesis SDK (#5548) fix: Link with boost libraries explicitly (#5546) chore: Fix compilation error with clang-20 and cleanup (#5543) test: Remove circular jtx.h dependencies (#5544) Decouple CredentialHelpers from xrpld/app/tx (#5487) fix: crash when trace-logging in tests (#5529) ...

…actoring-3 * ximinez/lending-refactoring-2: (57 commits) Fix formatting Remove `include(default)` from libxrpl profile (#5587) refactor: Change boost::shared_mutex to std::shared_mutex (#5576) Fix macos runner (#5585) Remove the type filter from "ledger" RPC command (#4934) refactor: Update date, libarchive, nudb, openssl, sqlite3, xxhash packages (#5567) test: Run unit tests regardless of 'Supported' amendment status (#5537) Retire Flow Cross amendment (#5562) chore: Update CI to use Conan 2 (#5556) fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513) chore: Add gcc-12 workaround (#5554) Add MPT related txns into issuer's account history (#5530) chore: Remove unused headers (#5526) fix: add allowTrustLineLocking flag for account_info (#5525) Downgrade required CMake version for Antithesis SDK (#5548) fix: Link with boost libraries explicitly (#5546) chore: Fix compilation error with clang-20 and cleanup (#5543) test: Remove circular jtx.h dependencies (#5544) Decouple CredentialHelpers from xrpld/app/tx (#5487) fix: crash when trace-logging in tests (#5529) ...

…actoring-4 * ximinez/lending-refactoring-3: (61 commits) fixup! Rename Transactor preflight functions Rename Transactor preflight functions fixup! Make preflight1 and preflight2 private static Transactor functions Make preflight1 and preflight2 private static Transactor functions Fix formatting Remove `include(default)` from libxrpl profile (#5587) refactor: Change boost::shared_mutex to std::shared_mutex (#5576) Fix macos runner (#5585) Remove the type filter from "ledger" RPC command (#4934) refactor: Update date, libarchive, nudb, openssl, sqlite3, xxhash packages (#5567) test: Run unit tests regardless of 'Supported' amendment status (#5537) Retire Flow Cross amendment (#5562) chore: Update CI to use Conan 2 (#5556) fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513) chore: Add gcc-12 workaround (#5554) Add MPT related txns into issuer's account history (#5530) chore: Remove unused headers (#5526) fix: add allowTrustLineLocking flag for account_info (#5525) Downgrade required CMake version for Antithesis SDK (#5548) fix: Link with boost libraries explicitly (#5546) ...

…actoring-4 * ximinez/lending-refactoring-3: (61 commits) fixup! Rename Transactor preflight functions Rename Transactor preflight functions fixup! Make preflight1 and preflight2 private static Transactor functions Make preflight1 and preflight2 private static Transactor functions Fix formatting Remove `include(default)` from libxrpl profile (#5587) refactor: Change boost::shared_mutex to std::shared_mutex (#5576) Fix macos runner (#5585) Remove the type filter from "ledger" RPC command (#4934) refactor: Update date, libarchive, nudb, openssl, sqlite3, xxhash packages (#5567) test: Run unit tests regardless of 'Supported' amendment status (#5537) Retire Flow Cross amendment (#5562) chore: Update CI to use Conan 2 (#5556) fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513) chore: Add gcc-12 workaround (#5554) Add MPT related txns into issuer's account history (#5530) chore: Remove unused headers (#5526) fix: add allowTrustLineLocking flag for account_info (#5525) Downgrade required CMake version for Antithesis SDK (#5548) fix: Link with boost libraries explicitly (#5546) ... Co-authored-by: Bronek Kozicki <[email protected]>

shawnxie999 added 3 commits April 1, 2025 10:53

initial

07e24d2

Merge remote-tracking branch 'upstream/develop' into mpt-acct-tx

d49e180

test

6991d74

shawnxie999 requested a review from a team as a code owner July 2, 2025 17:51

shawnxie999 requested review from gregtatcam and yinyiqian1 July 7, 2025 17:53

gregtatcam approved these changes Jul 7, 2025

View reviewed changes

yinyiqian1 approved these changes Jul 8, 2025

View reviewed changes

Merge branch 'develop' into mpt-acct-tx

749a668

shawnxie999 added 2 commits July 9, 2025 10:54

Merge branch 'develop' into mpt-acct-tx

d92db52

Merge branch 'develop' into mpt-acct-tx

4067c63

bthomee requested a review from a1q123456 July 10, 2025 15:00

Merge branch 'develop' into mpt-acct-tx

ac647a3

a1q123456 reviewed Jul 10, 2025

View reviewed changes

src/libxrpl/protocol/TxMeta.cpp Outdated Show resolved Hide resolved

update var name

1e00e63

a1q123456 approved these changes Jul 10, 2025

View reviewed changes

shawnxie999 added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Jul 10, 2025

shawnxie999 and others added 2 commits July 10, 2025 12:09

Merge branch 'develop' into mpt-acct-tx

a8fb236

Merge branch 'develop' into mpt-acct-tx

1d29d6f

shawnxie999 removed the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Jul 10, 2025

ximinez previously requested changes Jul 10, 2025

View reviewed changes

shawnxie999 and others added 2 commits July 11, 2025 09:30

test hardcoded ledger hash

87ea16a

Merge branch 'develop' into mpt-acct-tx

41b1227

shawnxie999 added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Jul 11, 2025

bthomee enabled auto-merge (squash) July 11, 2025 13:33

shawnxie999 added 3 commits July 11, 2025 10:22

set ref fee to 10

eb42956

use makeConfig

5bf6333

comment out hardcode hash

8bb46c5

shawnxie999 commented Jul 11, 2025

View reviewed changes

src/test/rpc/AccountTx_test.cpp Show resolved Hide resolved

bthomee merged commit b8626ea into XRPLF:develop Jul 11, 2025
24 checks passed

shawnxie999 mentioned this pull request Jul 14, 2025

Pass windows pipeline for hardcoded ledger hash AccountTx test #5561

Open

This was referenced Aug 27, 2025

Release 2.6.0 #5741

Merged

Release 2.6.0 #5742

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add MPT related txns into issuer's account history #5530

Add MPT related txns into issuer's account history #5530

Uh oh!

shawnxie999 commented Jul 2, 2025 •

edited

Loading

Uh oh!

gregtatcam left a comment

Uh oh!

mDuo13 commented Jul 8, 2025

Uh oh!

shawnxie999 commented Jul 8, 2025

Uh oh!

yinyiqian1 left a comment

Uh oh!

codecov bot commented Jul 8, 2025 •

edited

Loading

Uh oh!

Uh oh!

ximinez commented Jul 10, 2025

Uh oh!

ximinez left a comment

Uh oh!

shawnxie999 commented Jul 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Add MPT related txns into issuer's account history #5530

Add MPT related txns into issuer's account history #5530

Uh oh!

Conversation

shawnxie999 commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

High Level Overview of Change

Context of Change

Type of Change

API Impact

Uh oh!

gregtatcam left a comment

Choose a reason for hiding this comment

Uh oh!

mDuo13 commented Jul 8, 2025

Uh oh!

shawnxie999 commented Jul 8, 2025

Uh oh!

yinyiqian1 left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

ximinez commented Jul 10, 2025

Uh oh!

ximinez left a comment

Choose a reason for hiding this comment

Uh oh!

shawnxie999 commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

shawnxie999 commented Jul 2, 2025 •

edited

Loading

codecov bot commented Jul 8, 2025 •

edited

Loading

shawnxie999 commented Jul 10, 2025 •

edited

Loading