fix: Remove InvalidHotWallet Error from gateway_balances RPC handler #1830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@nkramer44, please, sign your commit. |
Contributor
Author
|
@kuznetsss I tried to work some git magic to sign 9db9de6, but it looks like I did something wrong. Should I just close this PR and re-open with a clean branch that has a signed commit? |
Collaborator
|
@nkramer44, up to you. I think you could hard reset your branch to the commit you need to sign, then sign it by |
…er to align with the behavior of rippled.
cindyyan317
approved these changes
Jan 17, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1830 +/- ##
===========================================
- Coverage 71.78% 71.75% -0.03%
===========================================
Files 324 324
Lines 13268 13265 -3
Branches 6743 6742 -1
===========================================
- Hits 9524 9518 -6
- Misses 1906 1907 +1
- Partials 1838 1840 +2 ☔ View full report in Codecov by Sentry. |
Contributor
|
@nkramer44 All checks passed. let's go 💯 |
kuznetsss
added a commit
to kuznetsss/clio
that referenced
this pull request
Feb 3, 2025
…RPLF#1830) Fixes XRPLF#1825 by removing the check in the gateway_balances RPC handler that returns the RpcInvalidHotWallet error code if one of the addresses supplied in the request's `hotwallet` array does not have a trustline with the `account` from the request. As stated in the original ticket, this change fixes a discrepancy in behavior between Clio and rippled, as rippled does not check for trustline existence when handling gateway_balances RPCs Co-authored-by: Sergey Kuznetsov <[email protected]>
kuznetsss
added a commit
to kuznetsss/clio
that referenced
this pull request
Feb 3, 2025
…RPLF#1830) Fixes XRPLF#1825 by removing the check in the gateway_balances RPC handler that returns the RpcInvalidHotWallet error code if one of the addresses supplied in the request's `hotwallet` array does not have a trustline with the `account` from the request. As stated in the original ticket, this change fixes a discrepancy in behavior between Clio and rippled, as rippled does not check for trustline existence when handling gateway_balances RPCs Co-authored-by: Sergey Kuznetsov <[email protected]>
kuznetsss
added a commit
to kuznetsss/clio
that referenced
this pull request
Feb 4, 2025
…RPLF#1830) Fixes XRPLF#1825 by removing the check in the gateway_balances RPC handler that returns the RpcInvalidHotWallet error code if one of the addresses supplied in the request's `hotwallet` array does not have a trustline with the `account` from the request. As stated in the original ticket, this change fixes a discrepancy in behavior between Clio and rippled, as rippled does not check for trustline existence when handling gateway_balances RPCs Co-authored-by: Sergey Kuznetsov <[email protected]>
kuznetsss
added a commit
that referenced
this pull request
Feb 4, 2025
#1873) Port of #1830 into release/2.3.1. Fixes #1825 by removing the check in the gateway_balances RPC handler that returns the RpcInvalidHotWallet error code if one of the addresses supplied in the request's `hotwallet` array does not have a trustline with the `account` from the request. As stated in the original ticket, this change fixes a discrepancy in behavior between Clio and rippled, as rippled does not check for trustline existence when handling gateway_balances RPCs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1825 by removing the check in the gateway_balances RPC handler that returns the RpcInvalidHotWallet error code if one of the addresses supplied in the request's
hotwalletarray does not have a trustline with theaccountfrom the request.As stated in the original ticket, this change fixes a discrepancy in behavior between Clio and rippled, as rippled does not check for trustline existence when handling gateway_balances RPCs