fix: gateway_balance discrepancy #1839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godexsoft
approved these changes
Jan 21, 2025
Collaborator
|
Idk if these are all the changes needed but what has been done so far looks good |
Contributor
Author
With #1830 together, I think we have fixed the known discrepancy of gateway_balance. |
kuznetsss
pushed a commit
to kuznetsss/clio
that referenced
this pull request
Feb 3, 2025
kuznetsss
pushed a commit
to kuznetsss/clio
that referenced
this pull request
Feb 4, 2025
kuznetsss
pushed a commit
to kuznetsss/clio
that referenced
this pull request
Feb 4, 2025
kuznetsss
added a commit
that referenced
this pull request
Feb 4, 2025
Port of #1839 into 2.3.1. Fixes #1832. rippled code: https://github.com/XRPLF/rippled/blob/develop/src/xrpld/rpc/handlers/GatewayBalances.cpp#L129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1832
rippled code:
https://github.com/XRPLF/rippled/blob/develop/src/xrpld/rpc/handlers/GatewayBalances.cpp#L129