Skip to content

Fix: failed clusterrolebinding when change release name or chart name #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2025
Merged

Fix: failed clusterrolebinding when change release name or chart name #1380

merged 1 commit into from
Sep 30, 2025

Conversation

FouoF
Copy link
Contributor

@FouoF FouoF commented Sep 29, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

The static roleref.name will not match the clusterrole name when helm release name or chart name is not "hami".

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@FouoF
fix failed rolebinding
bb480e5 
Signed-off-by: Jifei Wang <[email protected]>
@hami-robot hami-robot bot added kind/bug Something isn't working dco-signoff: yes labels Sep 29, 2025
@gemini-code-assist Gemini Code Assist
Copy link
Contributor

Summary of Changes

Hello @FouoF, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a bug where the ClusterRoleBinding would fail to match the ClusterRole name if the Helm release or chart name was customized away from the default "hami". By introducing a dynamic Helm template for the roleRef.name, the ClusterRoleBinding now correctly references the ClusterRole, ensuring proper authorization and functionality across different Helm deployment configurations.

Highlights

  • Dynamic ClusterRoleBinding Name: The roleRef.name in the clusterrolebinding.yaml has been updated from a static hami-scheduler to a dynamic Helm template {{ include "hami-vgpu.scheduler" . }}. This change ensures that the ClusterRole name correctly matches the generated name, preventing failures when the Helm release name or chart name is not "hami".
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@hami-robot hami-robot bot added the size/XS label Sep 29, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 29, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a bug in the ClusterRoleBinding for the scheduler. Previously, the roleRef.name was hardcoded to hami-scheduler, which caused issues when the Helm release name or chart name was changed, as the corresponding ClusterRole name is generated dynamically. By using the {{ include "hami-vgpu.scheduler" . }} template helper, the roleRef.name now correctly matches the ClusterRole name in all deployment scenarios. This is a good fix that improves the robustness of the Helm chart.

@FouoF
Copy link
Contributor Author

FouoF commented Sep 29, 2025

cc @wawa0210

@wawa0210
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

cc @wawa0210

@codecov Codecov
Copy link

codecov bot commented Sep 29, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.