Fix: failed clusterrolebinding when change release name or chart name #1380
Conversation
Signed-off-by: Jifei Wang <[email protected]>
Summary of ChangesHello @FouoF, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a bug where the ClusterRoleBinding would fail to match the ClusterRole name if the Helm release or chart name was customized away from the default "hami". By introducing a dynamic Helm template for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a bug in the ClusterRoleBinding for the scheduler. Previously, the roleRef.name was hardcoded to hami-scheduler, which caused issues when the Helm release name or chart name was changed, as the corresponding ClusterRole name is generated dynamically. By using the {{ include "hami-vgpu.scheduler" . }} template helper, the roleRef.name now correctly matches the ClusterRole name in all deployment scenarios. This is a good fix that improves the robustness of the Helm chart.
|
cc @wawa0210 |
cc @wawa0210 |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
/lgtm @archlitchi PTLK |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: archlitchi, FouoF, wawa0210 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The static roleref.name will not match the clusterrole name when helm release name or chart name is not "hami".
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: