Skip to content

Conversation

ashafaei
Copy link
Contributor

I guess Travis doesn't check builds with CUDNN active. You shouldn't be able to build the current dev if you have CUDNN active, and this patch fixes the errors.

@longjon
Copy link
Contributor

longjon commented Sep 30, 2014

Thanks, just came here to do this.

These errors were introduced by #1172... we should probably have Travis check USE_CUDNN, or at least remember to do a make everything manually when editing cuDNN code.

@longjon
Copy link
Contributor

longjon commented Sep 30, 2014

As this is now passing Travis and unbreaks the cuDNN dev build, I'm merging it. However note that dev is currently failing the CuDNNPoolingLayerTest.

longjon added a commit that referenced this pull request Sep 30, 2014
Fixed some errors in layer_factory and cudnn_pooling
@longjon longjon merged commit 1ddc1ac into BVLC:dev Sep 30, 2014
@shelhamer
Copy link
Member

@longjon the CuDNNPoolingLayerTest will keep failing until it's dropped.
The point of the test was to check the fallback behavior, which has since
been removed, so there is no way for it to pass.

The real fix would be to write the tests to use the layer factory and
configure the pooling_param for all the cases.

On Monday, September 29, 2014, longjon [email protected] wrote:

Merged #1186 #1186.


Reply to this email directly or view it on GitHub
#1186 (comment).

Evan Shelhamer

@longjon
Copy link
Contributor

longjon commented Sep 30, 2014

@shelhamer Yeah, layer factory tests make sense. I tried to convert the existing pooling layer test into a death test, but our testing setup doesn't seem to work with death tests. I'm in the process of removing the failing test and checking everything else now...

mitmul pushed a commit to mitmul/caffe that referenced this pull request Sep 30, 2014
Fixed some errors in layer_factory and cudnn_pooling
@longjon longjon mentioned this pull request Sep 30, 2014
RazvanRanca pushed a commit to RazvanRanca/caffe that referenced this pull request Nov 4, 2014
Fixed some errors in layer_factory and cudnn_pooling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants