Support flow jsx opening element type arguments #17028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58525 |
JLHwung
commented
Dec 16, 2024
|
|
||
| # Re-enable this test once prettier updated the snapshot | ||
| # https://github.com/babel/babel/pull/17028 | ||
| rm -r tests/format/flow/jsx/format.test.js |
JLHwung
commented
Dec 16, 2024
|
|
||
| JSX/invalid_unpaired_gt.js | ||
| JSX/invalid_unpaired_rcurly.js | ||
| JSX/jsx_type_args_types_disabled.js |
Contributor
Author
There was a problem hiding this comment.
In this test, <Component<T> /> is parsed with the flow parser option { types: false }, but we don't have a mirroring parser option.
The test is broken because we now support typeArguments in JSXOpeningElement
a7826f3 to
cbeba81
Compare
nicolo-ribaudo
approved these changes
Jan 8, 2025
Member
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
I would consider this to be a bugfix
liuxingbaoyu
approved these changes
This PR introduces support for the Flow type arguments in JSXOpeningElement, e.g.
<Component<string>></Component>. The implementation is mostly borrowed directly from the previous TypeScript implementation (#11912 and #14145).