Skip to content

Support flow jsx opening element type arguments #17028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JLHwung merged 9 commits into from
Jan 8, 2025
Merged

Support flow jsx opening element type arguments #17028

JLHwung merged 9 commits into from
Jan 8, 2025

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Dec 16, 2024

Q                       A
Fixed Issues? Babel does not support Flow type arguments in JSXOpeningElement
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This PR introduces support for the Flow type arguments in JSXOpeningElement, e.g. <Component<string>></Component>. The implementation is mostly borrowed directly from the previous TypeScript implementation (#11912 and #14145).

@babel-bot
Copy link
Collaborator

babel-bot commented Dec 16, 2024 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58525

JLHwung
JLHwung commented Dec 16, 2024
View reviewed changes
scripts/integration-tests/e2e-prettier.sh

# Re-enable this test once prettier updated the snapshot
# https://github.com/babel/babel/pull/17028
rm -r tests/format/flow/jsx/format.test.js
Copy link
Contributor Author

@JLHwung JLHwung Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @fisker

JLHwung
JLHwung commented Dec 16, 2024
View reviewed changes
scripts/parser-tests/flow/allowlist.txt

JSX/invalid_unpaired_gt.js
JSX/invalid_unpaired_rcurly.js
JSX/jsx_type_args_types_disabled.js
Copy link
Contributor Author

@JLHwung JLHwung