feat: Enable Audio module to work with Windows #1619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to e9075cb in 27 seconds. Click for details.
- Reviewed
14lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. instructor/multimodal.py:323
- Draft comment:
Consider centralizing MIME type normalization (e.g. via a mapping/dictionary) to avoid repeating if-conditions. This would improve maintainability if more MIME corrections are needed. - Reason this comment was not posted:
Confidence changes required:33%<= threshold85%None
Workflow ID: wflow_nkcu4X2OVODiHyIU
You can customize 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the Audio Module work with Windows .aac files which gives mime type error due to mismatch of mime type in WINDOWS.
Changes
Testing
Important
Maps Windows-specific MIME type
audio/vnd.dlna.adtstoaudio/aacinAudio.from_path()to support Windows.aacfiles.audio/vnd.dlna.adtstoaudio/aacinfrom_path()method ofAudioclass to handle Windows.aacfiles..aacfiles.This description was created by
for e9075cb. You can customize this summary. It will automatically update as commits are pushed.