fix(reask): handle ThinkingBlock in reask_anthropic_json #1604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reask_anthropic_json function was failing when Anthropic used extended thinking because it assumed response.content[0] was always a text block. With extended thinking, the first content can be a ThinkingBlock which doesn't have a .text attribute, causing AttributeError. Fixed by filtering for text blocks similar to the pattern in function_calls.py: - Filter content by c.type == "text" to exclude ThinkingBlocks - Use the last text block for consistent behavior - Add fallback handling if no text blocks are found Fixes #1596 Co-authored-by: Jason Liu <[email protected]>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
instructor | 7e66231 | Commit Preview URL | Jun 12 2025, 11:56 PM |
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 7e66231 in 34 seconds. Click for details.
- Reviewed
24lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. instructor/reask.py:76
- Draft comment:
Good handling of non-text blocks. Consider logging a warning when no text blocks are found to aid debugging in unexpected cases. - Reason this comment was not posted:
Confidence changes required:66%<= threshold85%None
2. instructor/reask.py:82
- Draft comment:
Using the last text block is reasonable, but the comment referencing 'function_calls.py:396-397' might become outdated. Consider describing the strategy instead of referring to line numbers. - Reason this comment was not posted:
Confidence changes required:40%<= threshold85%None
Workflow ID: wflow_ycy1huyeJ1pbjgbN
You can customize 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1596
The
reask_anthropic_jsonfunction was failing when Anthropic used extended thinking because it assumedresponse.content[0]was always a text block. With extended thinking, the first content can be aThinkingBlockwhich doesn't have a.textattribute, causingAttributeError.Solution
Fixed by filtering for text blocks similar to the pattern in
function_calls.py:c.type == "text"to exclude ThinkingBlocksTesting
The fix ensures compatibility with:
Generated with Claude Code
Important
Fixes
reask_anthropic_jsonto handleThinkingBlockby filtering for text blocks and adding fallback handling.reask_anthropic_jsoninreask.pyto handleThinkingBlockby filtering for text blocks.This description was created by
for 7e66231. You can customize this summary. It will automatically update as commits are pushed.