fix(deps): add dev and docs to project.optional-dependencies for uv compatibility #1581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompatibility Fixes issue #1580 where uv pip install -e '.[dev,docs,test-docs]' failed with warnings about missing extras. Added dev and docs dependencies to [project.optional-dependencies] while maintaining [dependency-groups] for poetry compatibility as documented in CONTRIBUTING.md. - Added dev dependencies to [project.optional-dependencies] - Added docs dependencies to [project.optional-dependencies] - Maintained existing [dependency-groups] for poetry compatibility - Verified uv pip install works without warnings - Verified lint checks pass Resolves #1580 Co-Authored-By: Jason Liu <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
jxnl
reviewed
Jun 3, 2025
pyproject.toml
Outdated
| "coverage<8.0.0,>=7.3.2", | ||
| "pyright<2.0.0", | ||
| "jsonref<2.0.0,>=1.1.0", | ||
| "black<25.0.0,>=24.10.0", |
There was a problem hiding this comment.
no need for black just use ruff
Addresses jxnl's feedback to remove black since ruff is used for formatting. Removed black from both [project.optional-dependencies] and [dependency-groups] dev sections. - Verified uv pip install -e '.[dev,docs,test-docs]' works without warnings - Verified ruff check passes - Maintained compatibility with existing workflows Co-Authored-By: Jason Liu <[email protected]>
|
✅ Confirmed commands work and builds successfully:
✅ Addressed feedback:
The fix resolves issue #1580 where uv couldn't find dev/docs extras, and now maintains compatibility with both uv and existing workflows without the unnecessary black dependency. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
instructor | c0d50c0 | Visit preview | Jun 03 2025, 06:04 PM |
…ncies for uv compatibility - Fixed anthropic dependency discrepancy by adding xmltodict to dependency-groups section - All provider dependencies now exist in both [project.optional-dependencies] and [dependency-groups] sections - Ensures compatibility with both uv and poetry dependency management workflows - Resolves issue #1580 where uv pip install failed to find dev and docs dependencies Co-Authored-By: Jason Liu <[email protected]>
Co-Authored-By: Jason Liu <[email protected]>
…ional-dependencies and dependency-groups - Added missing provider dependencies (phonenumbers, graphviz, sqlmodel, trafilatura, pydub, datasets) to [project.optional-dependencies] - Fixed google-genai dependency formatting consistency (removed trailing comma) - Ensures all provider dependencies are accessible via both uv and poetry workflows - Completes comprehensive uv/poetry compatibility as requested Co-Authored-By: Jason Liu <[email protected]>
- Updated lock file to include new provider dependencies - Ensures consistent dependency resolution across environments Co-Authored-By: Jason Liu <[email protected]>
johnwlockwood
approved these changes
Jun 3, 2025
There was a problem hiding this comment.
All optional dependencies install without warning.
% uv pip install -e ".[dev,docs,test-docs,datasets,pydub,trafilatura,sqlmodel,graphviz,litellm,google-genai,bedrock,perplexity,mistral,anthropic,groq,cohere,google-generativeai,vertexai,cerebras_cloud_sdk,fireworks-ai,writer]"
Resolved 231 packages in 160ms
Built instructor @ file:///Users/john/repos/instructor
Prepared 1 package in 169ms
Uninstalled 1 package in 0.57ms
Installed 1 package in 0.88ms
~ instructor==1.8.3 (from file:///Users/john/repos/instructor)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix uv pip install issue with missing dev and docs dependencies
Fixes #1580
Problem
uv pip install -e ".[dev,docs,test-docs]"was failing with warnings about missing extras becausedevanddocsdependencies were only defined in[dependency-groups]but not in[project.optional-dependencies].Solution
Added
devanddocsdependencies to[project.optional-dependencies]while maintaining the existing[dependency-groups]section for poetry compatibility, following the pattern documented in CONTRIBUTING.md. Additionally, synchronized ALL provider dependencies between both sections for comprehensive uv and poetry compatibility as requested.Changes
devdependencies to[project.optional-dependencies]docsdependencies to[project.optional-dependencies]xmltodict<0.15,>=0.13to[dependency-groups]section[project.optional-dependencies]: phonenumbers, graphviz, sqlmodel, trafilatura, pydub, datasets[dependency-groups]for poetry compatibilityuv pip install -e ".[dev,docs,test-docs]"works without warningsuv pip install -e ".[anthropic,groq,cohere]"works without warningsuv run ruff check .Testing
uv pip install -e ".[dev,docs,test-docs]"installs successfully without warningsuv pip install -e ".[anthropic,groq,cohere,google-genai,vertexai]"installs successfully without warningsuv pip install -e ".[phonenumbers,graphviz,sqlmodel,trafilatura,pydub,datasets]"installs successfully without warningsuv run ruff check .Link to Devin run
https://app.devin.ai/sessions/8e147cd3e28540509cd445e94efe33c1
This PR was requested by Jason Liu ([email protected]).