Fix documentation for dynamic model creation example #1567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Jason Liu <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
instructor | 722418d | Visit preview | May 27 2025, 08:18 PM |
|
can you add some simple tests to verify this works |
Co-Authored-By: Jason Liu <[email protected]>
Co-Authored-By: Jason Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix documentation for dynamic model creation example
This PR fixes the documentation issue described in #1558.
Changes
docs/concepts/models.mdto useField(description=description)instead of incorrectly using the description as a default valueFieldfrom pydanticdescriptioninstead ofdefaultThis change aligns the documentation with Pydantic's official documentation for dynamic model creation.
Link to Devin run
https://app.devin.ai/sessions/73b7d18e381a4feaa058d6ac34660262
Requested by
Jason Liu ([email protected])