Skip to content

Add new flag (-r) to support inverted RTS flow control #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2023
Merged

Add new flag (-r) to support inverted RTS flow control #98

merged 1 commit into from
Nov 27, 2023

Conversation

cian
Copy link
Contributor

@cian cian commented Oct 3, 2023

This is useful if you have a MAX485 connected to a Raspberry PI where you pull want RST low to transmit.

  • I would have liked to use -T to match -y/-Y, but this is already used. I've proposed -r to keep CLI-flag backwards compatibility.
  • I've also left the config file setting as "rts" so as to preserve backwards compatibility.

@cian
Add new flag (-r) to support inverted RTS flow control\n\nThis is use…
28cfe69 
…ful if you have a MAX485 connected to a Raspberry PI where you pull want RST low to transmit
@cian
Copy link
Contributor Author

cian commented Nov 27, 2023

@3cky ping

Do let me know if you've got any comments. I'd be keen to merge this upstream to get it into pre-built packages, etc.

Thanks

@3cky
Copy link
Owner

3cky commented Nov 27, 2023

LGTM, will merge. Sorry for the delay and thank you!

@3cky 3cky merged commit 4ee7e8a into 3cky:master Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cian @3cky