Skip to content

Conversation

aadhikar
Copy link
Contributor

Description:
The old ticket47714_test.py had compatibility issues. This ports the functionality to account_policy_login_attr_test.py using modern DSLdapObject methods.

Relates: #6753

Reviewed by: ???

@aadhikar aadhikar force-pushed the port-ticket47714-test branch 2 times, most recently from 4d0e180 to e779d47 Compare August 19, 2025 16:36
Copy link
Member

@vashirov vashirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM.

@aadhikar aadhikar force-pushed the port-ticket47714-test branch from e779d47 to 2d2c93c Compare August 25, 2025 12:43
@aadhikar aadhikar requested a review from vashirov August 25, 2025 12:44
@aadhikar
Copy link
Contributor Author

@vashirov made the changes! Thanks for the suggestion :)

Copy link
Contributor

@jchapma jchapma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests look good to me

Description:
The old ticket47714_test.py had compatibility issues.
This ports the functionality to account_policy_login_attr_test.py
using modern DSLdapObject methods.

Relates: 389ds#6753

Reviewed by: @vashirov, @jchapma (Thanks!)
@aadhikar aadhikar force-pushed the port-ticket47714-test branch from 2d2c93c to d172408 Compare September 3, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants