Skip to content

zml: use .host_pinned memory for ROCm #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
Merged

zml: use .host_pinned memory for ROCm #353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion zml/platform.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,9 @@ pub const Platform = struct {
const memory_target: pjrt.Memory.Kind = switch (memory) {
.host_unpinned => switch (platform.target) {
// Cuda doesn't have host_unpinned.
.cuda => .host_pinned,
// ROCm doesn't seem to have it either.
// TODO(gwenzek): investigate why it was not forced before.
.cuda, .rocm => .host_pinned,
else => .host_unpinned,
},
inline else => |t| t,
Expand Down
Loading